From 9b35d7e9ab0f1960495a5c96489fbe886c1d625e Mon Sep 17 00:00:00 2001 From: "Hana (Hyang-Ah) Kim" Date: Thu, 4 Jun 2020 16:46:42 +0000 Subject: [PATCH] package.json: change gopath/goroot/toolsGopath machine-overridable By setting them machine-overridable, client user values can be ignored in remote settings and the remote side can pick up the right value. I think go.alternateTools should be machine-overridable as well but will get to it next time. Manually tested by 1) setting go.gopath in user settings, vsce package, connecting to the remote host, sideloading vsix (do it after connecting, so the remote host can pick up the vsix), and checking the GOPATH with "Go: Current GOPATH" and also, by reinstalling all tools. 2) setting go.gopath in workspace settings and checking it's still doable. Fixes microsoft/vscode-go#2981 Updates microsoft/vscode-go#2576 Change-Id: I3390355d186280c13353d210adb51edfa3858032 Change-Id: I3390355d186280c13353d210adb51edfa3858032 GitHub-Last-Rev: 0463b8464fb51ac03a7dff81308569bf8b6a95cc GitHub-Pull-Request: golang/vscode-go#175 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236539 Reviewed-by: Rebecca Stambler --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 6bdbcab763..1dc7e8d305 100644 --- a/package.json +++ b/package.json @@ -879,13 +879,13 @@ ], "default": null, "description": "Specify GOPATH here to override the one that is set as environment variable. The inferred GOPATH from workspace root overrides this, if go.inferGopath is set to true.", - "scope": "resource" + "scope": "machine-overridable" }, "go.toolsGopath": { "type": "string", "default": "", "description": "Location to install the Go tools that the extension depends on if you don't want them in your GOPATH.", - "scope": "resource" + "scope": "machine-overridable" }, "go.goroot": { "type": [ @@ -894,7 +894,7 @@ ], "default": null, "description": "Specifies the GOROOT to use when no environment variable is set.", - "scope": "resource" + "scope": "machine-overridable" }, "go.testOnSave": { "type": "boolean",