-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implements test discovery. Tests are discovered as part of the type checking process, at the same time as method sets and xrefs, and cached. Does not implement the Modules command. Adds static detection of simple subtests. This provides a framework for static analysis of subtests but intentionally does not support more than the most trivial case in order to minimize the complexity of this CL. Fixes golang/go#59445. Updates golang/go#59445, golang/vscode-go#1602, golang/vscode-go#2445. Change-Id: Ief497977da09a1e07831e6c5f3b7d28d6874fd9f Reviewed-on: https://go-review.googlesource.com/c/tools/+/548675 Reviewed-by: Alan Donovan <[email protected]> Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
- Loading branch information
1 parent
8ba9169
commit dc4c525
Showing
11 changed files
with
1,025 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| // Copyright 2024 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| package testfuncs | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strconv" | ||
| "strings" | ||
| ) | ||
|
|
||
| // The functions in this file are copies of those from the testing package. | ||
| // | ||
| // https://cs.opensource.google/go/go/+/refs/tags/go1.22.5:src/testing/match.go | ||
|
|
||
| // uniqueName creates a unique name for the given parent and subname by affixing | ||
| // it with one or more counts, if necessary. | ||
| func (b *indexBuilder) uniqueName(parent, subname string) string { | ||
| base := parent + "/" + subname | ||
|
|
||
| for { | ||
| n := b.subNames[base] | ||
| if n < 0 { | ||
| panic("subtest count overflow") | ||
| } | ||
| b.subNames[base] = n + 1 | ||
|
|
||
| if n == 0 && subname != "" { | ||
| prefix, nn := parseSubtestNumber(base) | ||
| if len(prefix) < len(base) && nn < b.subNames[prefix] { | ||
| // This test is explicitly named like "parent/subname#NN", | ||
| // and #NN was already used for the NNth occurrence of "parent/subname". | ||
| // Loop to add a disambiguating suffix. | ||
| continue | ||
| } | ||
| return base | ||
| } | ||
|
|
||
| name := fmt.Sprintf("%s#%02d", base, n) | ||
| if b.subNames[name] != 0 { | ||
| // This is the nth occurrence of base, but the name "parent/subname#NN" | ||
| // collides with the first occurrence of a subtest *explicitly* named | ||
| // "parent/subname#NN". Try the next number. | ||
| continue | ||
| } | ||
|
|
||
| return name | ||
| } | ||
| } | ||
|
|
||
| // parseSubtestNumber splits a subtest name into a "#%02d"-formatted int | ||
| // suffix (if present), and a prefix preceding that suffix (always). | ||
| func parseSubtestNumber(s string) (prefix string, nn int) { | ||
| i := strings.LastIndex(s, "#") | ||
| if i < 0 { | ||
| return s, 0 | ||
| } | ||
|
|
||
| prefix, suffix := s[:i], s[i+1:] | ||
| if len(suffix) < 2 || (len(suffix) > 2 && suffix[0] == '0') { | ||
| // Even if suffix is numeric, it is not a possible output of a "%02" format | ||
| // string: it has either too few digits or too many leading zeroes. | ||
| return s, 0 | ||
| } | ||
| if suffix == "00" { | ||
| if !strings.HasSuffix(prefix, "/") { | ||
| // We only use "#00" as a suffix for subtests named with the empty | ||
| // string — it isn't a valid suffix if the subtest name is non-empty. | ||
| return s, 0 | ||
| } | ||
| } | ||
|
|
||
| n, err := strconv.ParseInt(suffix, 10, 32) | ||
| if err != nil || n < 0 { | ||
| return s, 0 | ||
| } | ||
| return prefix, int(n) | ||
| } | ||
|
|
||
| // rewrite rewrites a subname to having only printable characters and no white | ||
| // space. | ||
| func rewrite(s string) string { | ||
| b := []byte{} | ||
| for _, r := range s { | ||
| switch { | ||
| case isSpace(r): | ||
| b = append(b, '_') | ||
| case !strconv.IsPrint(r): | ||
| s := strconv.QuoteRune(r) | ||
| b = append(b, s[1:len(s)-1]...) | ||
| default: | ||
| b = append(b, string(r)...) | ||
| } | ||
| } | ||
| return string(b) | ||
| } | ||
|
|
||
| func isSpace(r rune) bool { | ||
| if r < 0x2000 { | ||
| switch r { | ||
| // Note: not the same as Unicode Z class. | ||
| case '\t', '\n', '\v', '\f', '\r', ' ', 0x85, 0xA0, 0x1680: | ||
| return true | ||
| } | ||
| } else { | ||
| if r <= 0x200a { | ||
| return true | ||
| } | ||
| switch r { | ||
| case 0x2028, 0x2029, 0x202f, 0x205f, 0x3000: | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
Oops, something went wrong.