unix: use libc stubs for OpenBSD pledge+unveil #146

jrick · 2023-02-14T15:35:26Z

Future OpenBSD releases will remove the syscall(2) interface.
This converts the Pledge and Unveil calls to use pledge(2) and
unveil(2) from libc, rather than indirectly through syscall(2).

Updates golang/go#63900.

gopherbot · 2023-02-14T15:44:19Z

This PR (HEAD: c8da038) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/468095 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-02-14T15:50:38Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-14T17:18:46Z

Message from Ian Lance Taylor:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-14T17:25:28Z

This PR (HEAD: 24ba2a1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/468095 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-02-14T17:32:33Z

This PR (HEAD: 6063f10) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/468095 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-02-14T18:19:52Z

Message from Josh Rickmar:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-14T19:31:50Z

Message from Josh Rickmar:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-14T19:31:55Z

This PR (HEAD: df13fe5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/468095 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-02-14T19:37:40Z

Message from Josh Rickmar:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-14T19:37:45Z

This PR (HEAD: e9d6a00) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/468095 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-10-22T16:35:58Z

This PR (HEAD: 3317d7f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/468095.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-22T17:16:47Z

Message from Josh Rickmar:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-24T09:46:04Z

Message from Joel Sing:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-24T13:56:00Z

Message from Josh Rickmar:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T03:33:21Z

This PR (HEAD: f4acfd1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/468095.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-01T03:46:02Z

Message from Josh Rickmar:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T03:46:07Z

This PR (HEAD: a06a685) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/468095.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-01T07:27:29Z

Message from Joel Sing:

Patch Set 10: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T07:33:43Z

Message from Gopher Robot:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T09:44:21Z

Message from Gopher Robot:

Patch Set 10: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T09:57:10Z

Message from Tobias Klauser:

Patch Set 10: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T13:16:59Z

Message from Aaron Bieber:

Patch Set 10: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T16:02:50Z

Message from Cherry Mui:

Patch Set 10: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T16:09:40Z

This PR (HEAD: 26b3bfc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/468095.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-01T16:16:23Z

Message from Josh Rickmar:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T23:58:21Z

Message from Cherry Mui:

Patch Set 11: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T00:23:44Z

Message from Josh Rickmar:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T00:23:45Z

Message from Cherry Mui:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T00:29:52Z

This PR (HEAD: cec5852) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/468095.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-02T00:48:22Z

This PR (HEAD: f868e74) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/468095.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

For both compatibility and security concerns, it is preferrable to perform system calls through the libc stubs rather than syscall(2). Besides making programs resilient to changing system call numbers, it removes an unnecessary use of the syscall(2) call which, if found by an attacker, could be abused to perform any system call. As OpenBSD 6.2 is the oldest supported version of OpenBSD, remove the handling of pledge on versions prior to this release. PledgeExecpromises is no longer usable on 6.2, as the execpromises is treated as required (unlike Pledge, where on 6.2 it is allowed but must be empty). The empty execpromises string is no longer converted to a nil pointer on 6.2. This fixes an out-of-bounds read where, on 6.2, an empty string would be passed to the deprecated pledge(2) API, which would interpret the pointer as an array of strings.

gopherbot · 2023-11-02T01:19:08Z

Message from Joel Sing:

Patch Set 13: -Code-Review Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T01:19:13Z

This PR (HEAD: ebc0461) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/468095.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-02T01:25:26Z

Message from Josh Rickmar:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T02:23:33Z

Message from Mauri de Souza Meneguzzo:

Patch Set 14: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T08:09:04Z

Message from Joel Sing:

Patch Set 14: -Hold Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T08:15:46Z

Message from Gopher Robot:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T08:22:12Z

Message from Gopher Robot:

Patch Set 14: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T10:47:32Z

Message from Joel Sing:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T13:08:14Z

Message from Josh Rickmar:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-02T18:44:54Z

Message from Bryan Mills:

Patch Set 15: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/468095.
After addressing review feedback, remember to publish your drafts!

Future OpenBSD releases will remove the syscall(2) interface. This converts the Pledge and Unveil calls to use pledge(2) and unveil(2) from libc, rather than indirectly through syscall(2). Updates golang/go#63900. Change-Id: I61e22d8f52f16c8f5e4c0717acae0d5bf4271503 GitHub-Last-Rev: ebc0461 GitHub-Pull-Request: #146 Reviewed-on: https://go-review.googlesource.com/c/sys/+/468095 Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Mauri de Souza Meneguzzo <[email protected]> Reviewed-by: Joel Sing <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> Run-TryBot: Joel Sing <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Aaron Bieber <[email protected]> Reviewed-by: Bryan Mills <[email protected]>

gopherbot · 2023-11-03T08:01:28Z

This PR is being closed because golang.org/cl/468095 has been merged.

jrick force-pushed the libc_pledge_unveil branch from e9d6a00 to 3317d7f Compare October 22, 2023 16:30

jrick force-pushed the libc_pledge_unveil branch from 3317d7f to f4acfd1 Compare November 1, 2023 03:29

jrick added 4 commits November 2, 2023 01:18

regenerate syscalls for all openbsd ports

56eca24

remove now unnecessary comment about openbsd <=6.3

6607d46

whack more useless comments

ebc0461

jrick force-pushed the libc_pledge_unveil branch from f868e74 to ebc0461 Compare November 2, 2023 01:18

gopherbot closed this Nov 3, 2023

unix: use libc stubs for OpenBSD pledge+unveil #146

unix: use libc stubs for OpenBSD pledge+unveil #146

Conversation

jrick commented Feb 14, 2023 • edited Loading

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Feb 14, 2023

gopherbot commented Oct 22, 2023

gopherbot commented Oct 22, 2023

gopherbot commented Oct 24, 2023

gopherbot commented Oct 24, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 2, 2023

gopherbot commented Nov 3, 2023

jrick commented Feb 14, 2023 •

edited

Loading