Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry: FileDescriptor should mention protoregistry.GlobalFiles.FindFileByPath as replacement #1092

Closed
marcellanz opened this issue Apr 19, 2020 · 0 comments · Fixed by #1093
Closed

registry: FileDescriptor should mention protoregistry.GlobalFiles.FindFileByPath as replacement #1092

marcellanz opened this issue Apr 19, 2020 · 0 comments · Fixed by #1093
Labels
documentation

Comments

@marcellanz
Copy link
Contributor

What version of protobuf and what language are you using?
Version: v1.4.0, Language: Go

What did you do?
I've used the function registry.go:FileDescriptor and got the deprecation note after upgrading to v1.4.0:

// Deprecated: Use protoregistry.GlobalFiles.RangeFilesByPath instead.

What did you expect to see?
I expected to use protoregistry.GlobalFiles.RangeFilesByPath.

What did you see instead?
The function protoregistry.GlobalFiles.RangeFilesByPath seems to be deprecated itself by https://go-review.googlesource.com/c/protobuf/+/182537 and is replaced by Files.FindFileByPath.

Anything else we should know about your project / environment?
none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proto: fix stale deprecation documentation on registry functions marcellanz/protobuf
2 participants
@dsnet @marcellanz