From fae4c4e3ad76c295c3d6d259f898136b4bf833a8 Mon Sep 17 00:00:00 2001 From: Filippo Valsorda Date: Wed, 28 Nov 2018 22:16:52 -0500 Subject: [PATCH] http2: confirm the test fix for golang/go#28762 was correct Fixes golang/go#28762 Change-Id: I8d8b74cd8836bbed3116b334f6595225a8f0a36e Reviewed-on: https://go-review.googlesource.com/c/151619 Reviewed-by: Brad Fitzpatrick --- http2/server_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/http2/server_test.go b/http2/server_test.go index b0a117f79..f26e910f8 100644 --- a/http2/server_test.go +++ b/http2/server_test.go @@ -2416,7 +2416,8 @@ func testRejectTLS(t *testing.T, max uint16) { func TestServer_Rejects_TLSBadCipher(t *testing.T) { st := newServerTester(t, nil, func(c *tls.Config) { - c.MaxVersion = tls.VersionTLS12 // workaround for golang.org/issue/28762 + // All TLS 1.3 ciphers are good. Test with TLS 1.2. + c.MaxVersion = tls.VersionTLS12 // Only list bad ones: c.CipherSuites = []uint16{ tls.TLS_RSA_WITH_RC4_128_SHA,