Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: When the fn function is executed, causing panic will cause the key to remain permanently. This leads to a series of problems. #139

Open
liqingqiya opened this issue May 21, 2020 · 0 comments

Comments

@liqingqiya
Copy link

liqingqiya commented May 21, 2020

When the fn function is executed, causing panic will cause the key to remain permanently. This leads to a series of problems.

goroutine 1

	Group.Do 
		// add 
		g.m[key] = c

		// execute fn()
		c.val, c.err = fn()  // panic;

		// delete key
		delete(g.m, key)

goroutine 2

	Group.Do 
		// lookup  
		if c, ok := g.m[key]; ok {
			g.mu.Unlock()
			c.wg.Wait()			// wait forever
			return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant