Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistenthash.go doesn't have a "Remove" method #115

Open
toli-belo opened this issue Apr 5, 2019 · 4 comments
Open

consistenthash.go doesn't have a "Remove" method #115

toli-belo opened this issue Apr 5, 2019 · 4 comments

Comments

@toli-belo
Copy link

curious how you guys use consistenthash.go without the Remove method. Isn't the whole beauty in the ability to make some keys unavail by removing them from the "ring" /hash value list?

@LiuNingqian
Copy link

Hi, Has this issue been resolved?

@thrawn01
Copy link

I'm trying to understand the use case here, you can effectively "remove" a peer by re-creating the hash with a new set of peers.

@LiuNingqian
Copy link

I'm trying to understand the use case here, you can effectively "remove" a peer by re-creating the hash with a new set of peers.

I also thought about the use case, but what I'm worried about is that if re-creating will change the old mapping peer.

@thrawn01
Copy link

thrawn01 commented Feb 10, 2022

It can change the mapping peer, but removing a peer will also change the mapping peer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants