Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln/cmd/govulncheck: TestCommand/main fail with Go tip since CL 596035 #68998

Closed
cherrymui opened this issue Aug 21, 2024 · 5 comments
Closed

x/vuln/cmd/govulncheck: TestCommand/main fail with Go tip since CL 596035 #68998

cherrymui opened this issue Aug 21, 2024 · 5 comments
Assignees
@zpavlinovic
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@cherrymui
Copy link
Member

cherrymui commented Aug 21, 2024 •
edited by gabyhelp
Loading

x/vuln's longtest builders started to fail consistently since (main repo's) CL 596035

https://ci.chromium.org/ui/p/golang/builders/ci/x_vuln-gotip-linux-amd64-longtest/b8738967372571184001/test-results

cc @golang/vulndb
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Aug 21, 2024
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Aug 21, 2024
@cherrymui cherrymui added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo and removed vulncheck or vulndb Issues for the x/vuln or x/vulndb repo labels Aug 21, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@cherrymui
Copy link
Member Author

cc @samthanawalla @matloob

@cherrymui cherrymui changed the title x/vuln: cmd/govulncheck.TestCommand/main fail with Go tip x/vuln: cmd/govulncheck.TestCommand/main fail with Go tip since CL 596035 Aug 21, 2024
@gabyhelp gabyhelp mentioned this issue Aug 21, 2024
Closed
@cherrymui cherrymui changed the title x/vuln: cmd/govulncheck.TestCommand/main fail with Go tip since CL 596035 x/vuln/cmd/govulncheck: TestCommand/main fail with Go tip since CL 596035 Aug 21, 2024
@zpavlinovic zpavlinovic self-assigned this Aug 21, 2024
@zpavlinovic
Copy link
Contributor

zpavlinovic commented Aug 21, 2024 •
edited by gabyhelp
Loading

I've created a CL for this: https://go-review.googlesource.com/c/vuln/+/605855

Just waiting for a review.

@zpavlinovic
Copy link
Contributor

The builders look good now. Closing.

@cherrymui
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpavlinovic zpavlinovic

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
4 participants
@zpavlinovic @gopherbot @cherrymui @gabyhelp