Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/fix: go fix . does not work with patch in go version #68604

Closed
sarathsp06 opened this issue Jul 26, 2024 · 2 comments
Closed

tools/fix: go fix . does not work with patch in go version #68604

sarathsp06 opened this issue Jul 26, 2024 · 2 comments

Comments

@sarathsp06
Copy link

Go version

go version go1.22.5 darwin/arm64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/S.SadasivanPillai/Library/Caches/go-build'
GOENV='/Users/S.SadasivanPillai/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/S.SadasivanPillai/go/pkg/mod'
GONOPROXY='github.com/shellagilehub/*'
GONOSUMDB='github.com/shellagilehub/*'
GOOS='darwin'
GOPATH='/Users/S.SadasivanPillai/go'
GOPRIVATE='github.com/shellagilehub/*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/S.SadasivanPillai/goroot/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/Users/S.SadasivanPillai/goroot/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.22.5'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/S.SadasivanPillai/projects/shellagilehub/donut_data/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/1n/4312fkc92x9f1wh374z96jsw0000gp/T/go-build1801288679=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

I ran 'go fix ./...' on my repository with go.mod indicating go1.22.5 as the go version.

What did you see happen?

It failed with message invalid -go=go1.22.5 but does not fail when go.mod is 1.22 it works

What did you expect to see?

No panic

@sarathsp06
Copy link
Author

I see that is fixed here https://go-review.googlesource.com/c/go/+/527342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants