x/tools/gopls: iferr completion content should adjust according to return type of function in scope

[golopot]

gopls version

golang.org/x/tools/gopls v0.14.2 golang.org/x/tools/[email protected] h1:sIw6vjZiuQ9S7s0auUUkHlWgsCkKZFWDHmrge8LYsnc= github.com/BurntSushi/[email protected] h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak= github.com/google/[email protected] h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38= github.com/sergi/[email protected] h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0= golang.org/x/exp/[email protected] h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y= golang.org/x/[email protected] h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0= golang.org/x/[email protected] h1:zxkM55ReGkDlKSM+Fu41A+zmbZuaPVbGMzvvdUPznYQ= golang.org/x/[email protected] h1:Vz7Qs629MkJkGyHxUlRHizWJRG2j8fbQKjELVSNhy7Q= golang.org/x/[email protected] h1:brbkEFfGwNGAEkykUOcryE/JiHUMMJouzE0fWWmz/QU= golang.org/x/[email protected] h1:ablQoSUd0tRdKxZewP80B+BaqeKJuVhuRxj/dkrun3k= golang.org/x/[email protected] h1:Oku7E+OCrXHyst1dG1z10etCTxewCHXNFLRlyMPbh3w= golang.org/x/[email protected] h1:KUas02EjQK5LTuIx1OylBQdKKZ9jeugs+HiqO5HormU= honnef.co/go/[email protected] h1:YGD4H+SuIOOqsyoLOpZDWcieM28W47/zRO7f+9V3nvo= mvdan.cc/[email protected] h1:JVf4NN1mIpHogBj7ABpgOyZc65/UUOkKQFkoURsz4MM= mvdan.cc/xurls/[email protected] h1:tzxjVAj+wSBmDcF6zBB7/myTy3gX9xvi8Tyr28AuQgc= go: go1.21.6

go env

.

What did you do?

Accept iferr completion in a function of type func() error

What did you see happen?

Completes to
if err != nil { return nil, err }

What did you expect to see?

Completes to if err != nil { return err }

Editor and settings

No response

Logs

No response

[hyangah]

Are you using VS Code Go extension?

If so, it's likely this is coming from the vscode go extension side
https://github.com/golang/vscode-go/blob/0b3fabc4c832194f59ca913f36f048aecd1f78ae/extension/snippets/go.json#L114.
This adds one more reason to deprecate this legacy snippet (golang/vscode-go#160)

For example, this screenshot is the sign that this completion comes from vscode-go side snippets.

[golopot]

Yes I am using VS Code Go extension

[suzmue]

There is a similar feature in gopls, postfix completion https://go.dev/issue/64178. It can be triggered by typing . after a variable of an error type (for example err.). It is return value aware and fills in the non-error return values as well, leaving the cursor where the returned error value will be.

This feature could be modified to work without the postfix, so will leave this open as a feature request for that.

[tttoad]

Hi @suzmue , I'm interested in this feature, but I'm working with neovim. Is there an example or documentation on how to call this function? I just need to know how to call it by gopls, thank you.