Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/completion: unrecognized failures #64488

Closed
gopherbot opened this issue Dec 1, 2023 · 35 comments
Closed

x/tools/gopls/internal/test/integration/completion: unrecognized failures #64488

gopherbot opened this issue Dec 1, 2023 · 35 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Dec 1, 2023 •
edited by bcmills
Loading 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == "" && date < "2024-01-01"

Issue created automatically to collect these failures.

Example (log):

panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18579 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0022470e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xd6e0e85?, 0xc00002d670?}, {0xc00002d738?, 0x1d?, 0xcc54100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00002d870, 0x1, 0xcc5ca1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc005d37d80?, 0xc002443d40?, 0x5e?}, {0xd689a15?, 0x3?}, 0xf0?, 0x6e?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0038b04e0, {0xdb72108, 0xc002dc4600}, 0xc0021fd320)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0038b04e0, {0xdb72108, 0xc002dc4600}, 0x0, {0xc001ea2b40, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18557
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 1, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 03:42 darwin-amd64-10_15 tools@b74ea80d go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18579 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0022470e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xd6e0e85?, 0xc00002d670?}, {0xc00002d738?, 0x1d?, 0xcc54100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00002d870, 0x1, 0xcc5ca1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc005d37d80?, 0xc002443d40?, 0x5e?}, {0xd689a15?, 0x3?}, 0xf0?, 0x6e?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0038b04e0, {0xdb72108, 0xc002dc4600}, 0xc0021fd320)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0038b04e0, {0xdb72108, 0xc002dc4600}, 0x0, {0xc001ea2b40, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18557
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 03:42 freebsd-386-12_3 tools@b74ea80d go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 14458 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0x35e20300, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x43e
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8bd0b49, 0x3a}, {0x32269b34, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x4f
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x32269c30, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xcab
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x32f85180, {0x32b626c0, 0x2, 0x2}, {0x8b7cd8d, 0xa}, 0x1, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x124
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x32b621c0, {0x8e12e7c, 0x33032858}, 0x332720b0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xe3b
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x32b621c0, {0x8e12e7c, 0x33032858}, 0x0, {0x34177628, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5c8
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3d
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5c
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x9d
2023-12-01 03:42 netbsd-amd64-9_3 tools@b74ea80d go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19246 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc004fc6c60, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10a0ce5?, 0xc00081d670?}, {0xc00081d738?, 0x1d?, 0x412e00?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00081d870, 0x1, 0x41b6fe?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00425fc80?, 0xc002e0dce0?, 0x5e?}, {0x1049b14?, 0x3?}, 0x20?, 0xb3?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00249c4e0, {0x1314ac8, 0xc001e66f60}, 0xc0025f8480)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00249c4e0, {0x1314ac8, 0xc001e66f60}, 0x0, {0xc002529518, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19395
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 03:42 netbsd-amd64-9_3 tools@b74ea80d go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17460 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00120df80, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x107cc51?, 0x714b?}, {0xc00042b690?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00042b898, 0x1, 0x47?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004257a80?, 0xc001c64180?, 0x5e?}, {0x1029354?, 0x3?}, 0xd0?, 0x6?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0003a19e0, {0x12d52b8, 0xc0026603f0}, 0xc004de0b40)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0003a19e0, {0x12d52b8?, 0xc0026603f0}, 0x0?, {0xc000af0468, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5
2023-12-01 03:42 openbsd-amd64-72 tools@b74ea80d go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17113 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0041f53e0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x107fab2?, 0xc9d9?}, {0xc004511690?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc004511898, 0x1, 0x35?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004c53480?, 0xc0041f4d20?, 0x5d?}, {0x102b09c?, 0x3?}, 0x70?, 0x66?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc001c353e0, {0x12d8298, 0xc005b3ddd0}, 0xc005b026c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc001c353e0, {0x12d8298?, 0xc005b3ddd0}, 0x0?, {0xc002672218, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 1, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 1, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 03:42 darwin-amd64-11_0 tools@b74ea80d go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 16818 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001cbc240, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c85ff1?, 0xd29d?}, {0xc000637690?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000637898, 0x1, 0x35?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc002695780?, 0xc005a69da0?, 0x5f?}, {0x1c32478?, 0x3?}, 0x60?, 0xf3?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0016a6ae0, {0x1edf9d8, 0xc00223d170}, 0xc001ebb320)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0016a6ae0, {0x1edf9d8?, 0xc00223d170}, 0xc001c9a2c0?, {0xc0012ce3b0, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5
2023-12-01 03:42 darwin-amd64-12_0 tools@b74ea80d go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19372 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001c9d1a0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x2187e85?, 0xc000f51670?}, {0xc000f51738?, 0x1d?, 0x16fb100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000f51870, 0x1, 0x1703a1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004b1d880?, 0xc000962ba0?, 0x5f?}, {0x2130a15?, 0x3?}, 0xf0?, 0xe2?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0011b35c0, {0x2619108, 0xc00288c390}, 0xc0010bdd40)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0011b35c0, {0x2619108, 0xc00288c390}, 0x0, {0xc00235ec90, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19382
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 03:42 darwin-amd64-13 tools@b74ea80d go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19473 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc000046060, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x2232e85?, 0xc000659670?}, {0xc000659738?, 0x1d?, 0x17a6200?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000659870, 0x1, 0x17aea1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0038ac080?, 0xc0020a7b60?, 0x5f?}, {0x21dba15?, 0x3?}, 0x30?, 0x1a?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0031e6d20, {0x26c4108, 0xc005459500}, 0xc0015cdb00)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0031e6d20, {0x26c4108, 0xc005459500}, 0x0, {0xc0029e2280, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19465
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 03:42 darwin-amd64-nocgo tools@b74ea80d go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17345 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0003c3e60, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x22a1d4a?, 0xc0008b3670?}, {0xc0008b3738?, 0x1d?, 0x1815500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0008b3870, 0x1, 0x181dd5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0019ae180?, 0xc001418f60?, 0x5f?}, {0x224a935?, 0x3?}, 0x20?, 0xe?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00243ae40, {0x27320c8, 0xc004899b30}, 0xc0038739e0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00243ae40, {0x27320c8, 0xc004899b30}, 0x0, {0xc0012b9890, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17292
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@findleyr findleyr assigned findleyr and adonovan and unassigned adonovan Dec 1, 2023
@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2023

It looks like this bug was triggered by https://go.dev/cl/541277 (the panics appear to be completion tests), but that CL is almost certainly not the root cause.

So this is great news: since this looks highly reproducible, at least on BSDs, it is likely that we will be able to root cause a formerly latent bug.

CC @adonovan

@dmitshur dmitshur mentioned this issue Dec 1, 2023
Open
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 netbsd-amd64-9_3 tools@d146c601 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 16931 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc000af82a0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1061033?, 0x714b?}, {0xc00077f658?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00077f870, 0x1, 0x670545?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004d8aa00?, 0xc00166daa0?, 0x5e?}, {0x100a4fe?, 0x3?}, 0xa0?, 0x57?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0021b9920, {0x12ce3c0, 0xc0019e7c80}, 0xc0038ff200)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0021b9920, {0x12ce3c0?, 0xc0019e7c80}, 0x12c5d00?, {0xc0007d0aa8, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 16889
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 03:42 aix-ppc64 tools@b74ea80d go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 16889 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xa000100012c2ae0, 0x58})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x50c
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x100a8b581?, 0x10d74?}, {0xa000100011415e0?, 0x1d?, 0x0?})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x58
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xa000100005bf828, 0x1, 0x100010d40?})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xbb4
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xa00010000636f80?, 0xa00010000c3d280?, 0x7b?}, {0x100a343c3?, 0x3?}, 0xa?, 0x0?)
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xa00010003b14ba0, {0x110210bd0, 0xa000100000e4270}, 0xa00010003e438c0)
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xea0
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xa00010003b14ba0, {0x110210bd0?, 0xa000100000e4270}, 0xa00010001a16000?, {0xa00010000e3e2d8, 0x7})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x654
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3c
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x74
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 16873
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xc8
2023-12-01 03:42 dragonfly-amd64-622 tools@b74ea80d go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17111 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc003028cc0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10611fc?, 0x714b?}, {0xc000c71658?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000c71870, 0x1, 0x670805?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00614ad00?, 0xc0019ace40?, 0x5e?}, {0x100a7a5?, 0x3?}, 0x20?, 0xbe?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc000f34a80, {0x12ce3c0, 0xc0021a3590}, 0xc005266000)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc000f34a80, {0x12ce3c0?, 0xc0021a3590}, 0xc003e98090?, {0xc0028a6158, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17082
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 03:42 openbsd-amd64-72 tools@b74ea80d go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18804 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0020b2a80, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1062dc5?, 0x289d1?}, {0xc000969658?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000969870, 0x1, 0x41173e?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00429af00?, 0xc0020b2000?, 0x5e?}, {0x100b1a4?, 0x3?}, 0xf0?, 0x3c?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc004799aa0, {0x12d0280, 0xc0021223c0}, 0xc005d34000)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc004799aa0, {0x12d0280?, 0xc0021223c0}, 0xc0034b1404?, {0xc001766518, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18788
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 16:00 darwin-amd64-12_0 tools@d146c601 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17270 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001a26f00, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c694d2?, 0xc9d9?}, {0xc000bcd658?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000bcd870, 0x1, 0x1275e65?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00322cf00?, 0xc003875800?, 0x5f?}, {0x1c12731?, 0x3?}, 0x40?, 0x89?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00823aba0, {0x1ed7b60, 0xc002fd12c0}, 0xc00036a240)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00823aba0, {0x1ed7b60?, 0xc002fd12c0}, 0xc000a5bf60?, {0xc0027e8600, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17244
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 16:00 darwin-amd64-12_0 tools@d146c601 go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19507 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0021fbb60, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xb87ee85?, 0xc00004b670?}, {0xc00004b738?, 0x1d?, 0xadf2100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00004b870, 0x1, 0xadfaa1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc001d21d80?, 0xc005e39620?, 0x5f?}, {0xb827a15?, 0x3?}, 0xc0?, 0x5a?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc005f91140, {0xbd10108, 0xc005272720}, 0xc00017dc20)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc005f91140, {0xbd10108, 0xc005272720}, 0x0, {0xc000fc4c40, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19065
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 16:00 darwin-amd64-nocgo tools@d146c601 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18691 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0007739e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c68357?, 0x2c33a?}, {0xc000409658?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000409870, 0x1, 0x1274e45?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0059d8500?, 0xc00195a300?, 0x5f?}, {0x1c11611?, 0x3?}, 0xf0?, 0x43?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0037373e0, {0x1ed67a0, 0xc002de2cc0}, 0xc000a91e60)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0037373e0, {0x1ed67a0?, 0xc002de2cc0}, 0xc000501760?, {0xc0037bce20, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18681
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 16:00 netbsd-386-9_3 tools@d146c601 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 14246 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0x9b25200, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x445
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8bff28c, 0x3a}, {0x9d4bb1c, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x4f
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x9d4bc1c, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xc96
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0xaad5f80, {0x9e0e380, 0x2, 0x2}, {0x8ba82a8, 0xa}, 0x1, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x126
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x9e0e100, {0x8e56a1c, 0xa210570}, 0x9fa8210)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf26
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x9e0e100, {0x8e56a1c, 0xa210570}, 0x0, {0x9b00528, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5ad
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3d
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5a
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 14214
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x93
2023-12-01 16:00 netbsd-386-9_3 tools@d146c601 go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 14424 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xbd90f00, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x466
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8c2cfa2, 0x3a}, {0x9ae9b84, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x4f
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x9ae9c1c, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xc8a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0xd274d00, {0x9921b40, 0x2, 0x2}, {0x8bd594e, 0xa}, 0x1, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x13e
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x99218c0, {0x8e88b18, 0xa744120}, 0xd702188)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xdff
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x99218c0, {0x8e88b18, 0xa744120}, 0x0, {0xbffa1c0, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x592
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3d
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5a
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 14420
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x93

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 darwin-amd64-11_0 tools@d146c601 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18786 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc003f39140, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c694d2?, 0x273da?}, {0xc000f65658?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000f65870, 0x1, 0x1010a5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00287a200?, 0xc0031593e0?, 0x5f?}, {0x1c12731?, 0x3?}, 0xc0?, 0xc1?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc002e4c5a0, {0x1ed7b60, 0xc00110b050}, 0xc002d346c0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc002e4c5a0, {0x1ed7b60?, 0xc00110b050}, 0x1177ccc?, {0xc004cc6910, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18780
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 16:00 darwin-amd64-nocgo tools@d146c601 go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17407 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001149c80, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x425ed4a?, 0xc000605670?}, {0xc000605738?, 0x1d?, 0x37d2500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000605870, 0x1, 0x37dad5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004308300?, 0xc001b8e960?, 0x5f?}, {0x4207935?, 0x3?}, 0x40?, 0xef?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0026f9ec0, {0x46ef0c8, 0xc001fd5bf0}, 0xc00244dd40)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0026f9ec0, {0x46ef0c8, 0xc001fd5bf0}, 0x0, {0xc001fd6230, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17455
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2023

So this is almost certainly related to positions getting mangled while fixing dangling selectors (https://go.dev/issue/64335 seems well-timed!).

What's really interesting is that it's a non-deterministic failure, and seemingly only on certain builders. I'm setting up a gomote instance to investigate further, as I cannot reproduce locally.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 freebsd-386-13_0 tools@d146c601 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 13391 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0x329c73e0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x43e
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8bd0b49, 0x3a}, {0x326a9b34, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x4f
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x326a9c30, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xcab
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x338efa00, {0x322afd80, 0x2, 0x2}, {0x8b7cd8d, 0xa}, 0x1, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x124
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x322afa40, {0x8e12e7c, 0x347ad1e8}, 0x3444e0b0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xe3b
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x322afa40, {0x8e12e7c, 0x347ad1e8}, 0x0, {0x3306c508, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5c8
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3d
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5c
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x9d

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 openbsd-amd64-72 tools@d146c601 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 16862 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc006248840, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x107fab2?, 0x714b?}, {0xc000ba5690?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000ba5898, 0x1, 0x47?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc002da4a00?, 0xc006166d20?, 0x5d?}, {0x102b09c?, 0x3?}, 0x80?, 0xa0?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc005873500, {0x12d8298, 0xc0023793b0}, 0xc00575d680)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc005873500, {0x12d8298?, 0xc0023793b0}, 0x0?, {0xc0027c4678, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5
2023-12-01 16:00 openbsd-amd64-72 tools@d146c601 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17672 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0034c7140, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1062dc5?, 0xcebe?}, {0xc0008f5658?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0008f5870, 0x1, 0x41173e?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc000c8ca80?, 0xc0016d8b40?, 0x5e?}, {0x100b1a4?, 0x3?}, 0x10?, 0x38?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00071a5a0, {0x12d0280, 0xc001280960}, 0xc005ecc000)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00071a5a0, {0x12d0280?, 0xc001280960}, 0xc004e6ff70?, {0xc00278cb28, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17666
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2023

Of course, I've run this hundreds of times on both netbsd and openbsd gomotes, with 0 failures so far.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-arm64-12 tools@c4f958a6 go@fbfe62bc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17817 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0x140052bcd20, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x474
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1037e79d0?, 0x14000c91650?}, {0x14000c91718?, 0x1d?, 0x14000c91500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x28
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x14000c91850, 0x1, 0x14000c917d8?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xa28
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0x140048a2f00?, 0x14000399a40?, 0x5e?}, {0x103790413?, 0x3?}, 0xa0?, 0x72?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0xfc
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x140035e35c0, {0x103c70fc8, 0x14006f1a720}, 0x140001b0480)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xae8
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x140035e35c0, {0x103c70fc8, 0x14006f1a720}, 0x0, {0x14004db1cf0, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x534
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x34
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x58
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17810
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x98

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-12_0 tools@c4f958a6 go@fbfe62bc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17709 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0025686c0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8cffb10?, 0xc00075b670?}, {0xc00075b738?, 0x1d?, 0x8272100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00075b870, 0x1, 0x827aa1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0056ea300?, 0xc00112cc60?, 0x5f?}, {0x8ca8617?, 0x3?}, 0x80?, 0x7?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc002975800, {0x91912c8, 0xc00513cdb0}, 0xc001f9d680)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc002975800, {0x91912c8, 0xc00513cdb0}, 0x0, {0xc002698160, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17701
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2023

Aha, ok I understand and can reproduce this locally now.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-13 tools@c4f958a6 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18602 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc003415200, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c6a31d?, 0x27839?}, {0xc000aab658?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000aab870, 0x1, 0x1010a5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0014c6580?, 0xc001c559e0?, 0x5f?}, {0x1c134f3?, 0x3?}, 0xe0?, 0xca?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0069d5020, {0x1ed8de0, 0xc00417aa20}, 0xc001342120)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0069d5020, {0x1ed8de0?, 0xc00417aa20}, 0xc00407ac04?, {0xc00113f600, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18671
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 18:26 dragonfly-amd64-622 tools@c4f958a6 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18124 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00d128f00, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x107f214?, 0x29fc2?}, {0xc004103690?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc004103898, 0x1, 0x2c?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0027f8100?, 0xc001cdfce0?, 0x5d?}, {0x102b95d?, 0x3?}, 0x0?, 0x40?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc000304ea0, {0x12d7ab8, 0xc0014fc360}, 0xc00056e000)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc000304ea0, {0x12d7ab8?, 0xc0014fc360}, 0xc003d40484?, {0xc000626cf8, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5
2023-12-01 18:26 freebsd-amd64-13_0 tools@c4f958a6 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18254 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00012be60, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1085975?, 0x2b16a?}, {0xc000611690?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000611898, 0x1, 0x2c?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00545d080?, 0xc000422ba0?, 0x5e?}, {0x1031e73?, 0x3?}, 0x60?, 0x89?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc001dff500, {0x12df158, 0xc002081a70}, 0xc00372ec60)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc001dff500, {0x12df158?, 0xc002081a70}, 0x576615?, {0xc001ad1538, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5
2023-12-01 18:26 netbsd-386-9_3 tools@c4f958a6 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 14845 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xb379980, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x43e
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8bca3ca, 0x3a}, {0x9defb34, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x4f
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x9defc30, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xcab
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0xc6d0700, {0x9819040, 0x2, 0x2}, {0x8b7673c, 0xa}, 0x1, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x124
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x9818d80, {0x8e0bd28, 0xa9dd848}, 0xc7f0f20)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xe3b
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x9818d80, {0x8e0bd28, 0xa9dd848}, 0x0, {0xa1faa18, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5c8
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3d
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5c
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x9d
2023-12-01 18:26 openbsd-amd64-72 tools@c4f958a6 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17132 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00204f680, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x107fcfd?, 0x10d74?}, {0xc000675690?, 0x1d?, 0x0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000675898, 0x1, 0x34?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc001482200?, 0xc00085e3c0?, 0x5e?}, {0x102b25e?, 0x3?}, 0xe0?, 0x38?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc000863e60, {0x12d88d8, 0xc00333f620}, 0xc0010f0000)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc000863e60, {0x12d88d8?, 0xc00333f620}, 0x0?, {0xc0020d91f8, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 freebsd-amd64-12_3 tools@c4f958a6 go@5a2161ce x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17940 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001765320, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10a9989?, 0xc001309670?}, {0xc001309738?, 0x1d?, 0x413600?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc001309870, 0x1, 0x41be7e?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004a37a80?, 0xc002ea1bc0?, 0x5e?}, {0x1052593?, 0x3?}, 0xf0?, 0xa?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc008ca6d20, {0x131e948, 0xc002359590}, 0xc007350a20)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc008ca6d20, {0x131e948, 0xc002359590}, 0x0, {0xc001d5a4e8, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17901
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/546655 mentions this issue: gopls/internal/lsp/cache/parsego: clamp positions when fixing statements

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 netbsd-386-9_3 tools@c4f958a6 go@70c7fb75 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 14964 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xb9033e0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x466
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8c2e14d, 0x3a}, {0xa689b84, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x4f
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xa689c1c, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xc8a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0xb982680, {0xa846400, 0x2, 0x2}, {0x8bd6a70, 0xa}, 0x1, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x13e
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x9d7e400, {0x8e8a108, 0xa1cd3f8}, 0x9974d88)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xdff
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x9d7e400, {0x8e8a108, 0xa1cd3f8}, 0x0, {0x9c49428, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x592
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3d
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5a
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 14950
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x93

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 freebsd-amd64-13_0 tools@c4f958a6 go@40f6fbf1 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18175 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc000ef93e0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10a9989?, 0xc000c6b670?}, {0xc000c6b738?, 0x1d?, 0x413600?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000c6b870, 0x1, 0x41be7e?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc003c44780?, 0xc001a70c60?, 0x5e?}, {0x1052593?, 0x3?}, 0xe0?, 0x5a?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0006b5620, {0x131e948, 0xc000617c80}, 0xc002cb3320)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0006b5620, {0x131e948, 0xc000617c80}, 0x0, {0xc002be6318, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18529
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 18:26 linux-amd64-race tools@c4f958a6 go@40f6fbf1 x/tools/gopls/internal/test/integration/completion (log) 
panic: /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17862 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00470f680, 0x58})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x5fc
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x17c677f, 0x3a}, {0xc000aa13a8, 0x1, 0x1})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x54
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000aa1598, 0x1, 0x7f96c89c7b98?})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0x14bd
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0xc0009084b0, {0xc008710480, 0x2, 0x2}, {0x176eb07, 0xa}, 0x1, 0x0)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x286
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00281f6e0, {0x1b25360, 0xc003bd88a0}, 0xc002ca4240)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1b4c
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00281f6e0, {0x1b25360, 0xc003bd88a0}, 0x0, {0xc0018143c9, 0x7})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0xab9
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x75
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x92
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17850
	/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x125
2023-12-01 18:26 windows-amd64-2016 tools@c4f958a6 go@40f6fbf1 x/tools/gopls/internal/test/integration/completion (log) 
2023/12/01 20:17:02 error killing the Go command: TerminateProcess: Access is denied.
panic: C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18256 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0005e1080, 0x58})
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1e4d342?, 0xc00069d670?}, {0xc00069d738?, 0x1d?, 0x11a2000?})
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00069d870, 0x1, 0x11aa8a9?})
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc005540a80?, 0xc000b91900?, 0x73?}, {0x1df3623?, 0x3?}, 0x20?, 0x1b?)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc006414a20, {0x20c3808, 0xc00239c990}, 0xc00218c480)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc006414a20, {0x20c3808, 0xc00239c990}, 0x0, {0xc001fd8058, 0x7})
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	C:/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18293
	C:/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-arm64-11 tools@c4f958a6 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18340 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0x1400221a6c0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x474
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x102d6ba10?, 0x14000665650?}, {0x14000665718?, 0x1d?, 0x14000665500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x28
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x14000665850, 0x1, 0x140006657d8?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xa28
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0x14005e97980?, 0x1400194d440?, 0x5f?}, {0x102d14453?, 0x3?}, 0x40?, 0x7c?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0xfc
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x140011f8ba0, {0x1031f4fc8, 0x14005d10300}, 0x14005e7ab40)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xae8
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x140011f8ba0, {0x1031f4fc8, 0x14005d10300}, 0x0, {0x140073a5a20, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x534
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x34
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x58
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18319
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x98
2023-12-01 18:26 freebsd-386-12_3 tools@c4f958a6 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 14738 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0x2aa9cea0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x466
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x8c349f7, 0x3a}, {0x2a847b84, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x4f
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x2a847c1c, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xc8a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x2b1d4c00, {0x2d958fc0, 0x2, 0x2}, {0x8bdd163, 0xa}, 0x1, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x13e
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x2d958e00, {0x8e917d8, 0x2adfc540}, 0x2d997b08)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xdff
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x2d958e00, {0x8e917d8, 0x2adfc540}, 0x0, {0x2ce44570, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x592
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3d
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5a
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 14621
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x93
2023-12-01 18:26 netbsd-amd64-9_3 tools@c4f958a6 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17048 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00182ecc0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10a1f10?, 0xc00063f670?}, {0xc00063f738?, 0x1d?, 0x412e00?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00063f870, 0x1, 0x41b6fe?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004086180?, 0xc001a708a0?, 0x5e?}, {0x104acb6?, 0x3?}, 0xa0?, 0x44?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc005cb25a0, {0x1316148, 0xc003a8ecc0}, 0xc006c54120)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc005cb25a0, {0x1316148, 0xc003a8ecc0}, 0x0, {0xc00085b2e8, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17026
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-12_0 tools@c4f958a6 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19355 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001913b60, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x551cb50?, 0xc00076b670?}, {0xc00076b738?, 0x1d?, 0x4a8f100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00076b870, 0x1, 0x4a97a1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc003e2bb00?, 0xc002ca9d40?, 0x5f?}, {0x54c5657?, 0x3?}, 0xa0?, 0xaa?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc001207620, {0x59ae2c8, 0xc000e644e0}, 0xc00644f8c0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc001207620, {0x59ae2c8, 0xc000e644e0}, 0x0, {0xc0018fa9b8, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19375
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 18:26 darwin-amd64-12_0 tools@c4f958a6 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 16734 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0037da240, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c86dbc?, 0x714b?}, {0xc0007e3690?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0007e3898, 0x1, 0x47?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00233d080?, 0xc002d7ee40?, 0x5f?}, {0x1c331ba?, 0x3?}, 0x0?, 0xb6?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0085fdf20, {0x1ee0bd8, 0xc005af2ae0}, 0xc003eaa7e0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0085fdf20, {0x1ee0bd8?, 0xc005af2ae0}, 0x0?, {0xc001f68140, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5
2023-12-01 18:26 darwin-amd64-13 tools@c4f958a6 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19776 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0024af0e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xf5e7b50?, 0xc0007d3670?}, {0xc0007d3738?, 0x1d?, 0xeb5a100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0007d3870, 0x1, 0xeb62a1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004225b00?, 0xc00039c000?, 0x5e?}, {0xf590657?, 0x3?}, 0xc0?, 0x24?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00984d6e0, {0xfa792c8, 0xc001919140}, 0xc003dff560)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00984d6e0, {0xfa792c8, 0xc001919140}, 0x0, {0xc002a10490, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19769
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 18:26 openbsd-amd64-72 tools@c4f958a6 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17648 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00186b980, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10a3c2f?, 0xc000c11670?}, {0xc000c11738?, 0x1d?, 0x412f00?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000c11870, 0x1, 0x41b79e?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc001debc80?, 0xc003d21a40?, 0x5e?}, {0x104b95b?, 0x3?}, 0x30?, 0x10?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc001a5d6e0, {0x1317e68, 0xc009acd650}, 0xc000175e60)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc001a5d6e0, {0x1317e68, 0xc009acd650}, 0x0, {0xc005b91fb8, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17780
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 21:03 aix-ppc64 tools@58556d12 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18272 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xa00010001d03440, 0x58})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x504
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x100ada126?, 0xa00010000f21618?}, {0xa00010000f216e0?, 0x1d?, 0x0?})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x58
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xa00010000f21840, 0x1, 0xa00010000f21798?})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xb94
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xa0001000053e580?, 0xa00010000eb2480?, 0x7b?}, {0x100a827f0?, 0x3?}, 0xa?, 0x0?)
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xa000100018a1860, {0x110216f78, 0xa0001000310f6b0}, 0xa0001000321ed80)
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xdac
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xa000100018a1860, {0x110216f78, 0xa0001000310f6b0}, 0x0, {0xa000100024b46b8, 0x7})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x628
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3c
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x74
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18760
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xc8
2023-12-01 21:03 darwin-amd64-13 tools@58556d12 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19238 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00145bda0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x6500b50?, 0xc00086f670?}, {0xc00086f738?, 0x1d?, 0x5a73200?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00086f870, 0x1, 0x5a7ba1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00407b180?, 0xc0014c87e0?, 0x5f?}, {0x64a9657?, 0x3?}, 0xf0?, 0xb7?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc004ff7f20, {0x69922c8, 0xc003f7d680}, 0xc000a93320)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc004ff7f20, {0x69922c8, 0xc003f7d680}, 0x0, {0xc0039d47d0, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19227
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 21:03 openbsd-amd64-72 tools@58556d12 go@5d1287fa x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18402 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001639860, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10a3c2f?, 0xc000653670?}, {0xc000653738?, 0x1d?, 0x412f00?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000653870, 0x1, 0x41b79e?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0005ba500?, 0xc0005b5c20?, 0x5e?}, {0x104b95b?, 0x3?}, 0xd0?, 0xe3?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0011227e0, {0x1317e68, 0xc004f7fef0}, 0xc002536d80)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0011227e0, {0x1317e68, 0xc004f7fef0}, 0x0, {0xc001757028, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18187
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 21:03 openbsd-amd64-72 tools@58556d12 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19499 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0029327e0, 0x58})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x10a3c2f?, 0xc0009b9670?}, {0xc0009b9738?, 0x1d?, 0x412f00?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0009b9870, 0x1, 0x41b79e?})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004750180?, 0xc002d3c3c0?, 0x5c?}, {0x104b95b?, 0x3?}, 0x40?, 0x42?)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00009d200, {0x1317e68, 0xc0034b03c0}, 0xc0009fc480)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00009d200, {0x1317e68, 0xc0034b03c0}, 0x0, {0xc003526258, 0x7})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19471
	/tmp/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-nocgo tools@c4f958a6 go@f7a79cb5 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17385 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc002eaefc0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c691a2?, 0x10d74?}, {0xc001025658?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc001025870, 0x1, 0x1274e45?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd5d
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc002ca7a00?, 0xc001ab04e0?, 0x5e?}, {0x1c123d3?, 0x3?}, 0xd0?, 0x10?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0011865a0, {0x1ed7a20, 0xc003269710}, 0xc003cf1320)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0x1005
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0011865a0, {0x1ed7a20?, 0xc003269710}, 0xc000eb2f60?, {0xc0026d6a30, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x609
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17377
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 21:03 darwin-amd64-13 tools@58556d12 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18819 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0005750e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c86dbc?, 0x2b16a?}, {0xc000769690?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000769898, 0x1, 0x2c?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc005a5e300?, 0xc00233f9e0?, 0x5f?}, {0x1c331ba?, 0x3?}, 0x70?, 0x29?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc004544e40, {0x1ee0bd8, 0xc005db8540}, 0xc000d84240)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc004544e40, {0x1ee0bd8?, 0xc005db8540}, 0x16fc080?, {0xc0011cb6f0, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 21:03 linux-ppc64-sid-buildlet tools@58556d12 go@5d1287fa x/tools/gopls/internal/test/integration/completion (log) 
panic: /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17386 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0027852c0, 0x58})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x4e8
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xc8f021?, 0xc00087b618?}, {0xc00087b6e0?, 0x1d?, 0x0?})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x58
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00087b840, 0x1, 0xe0?})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xb68
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0041d0e80?, 0xc002d2dda0?, 0x5a?}, {0xc371ac?, 0x3?}, 0x0?, 0x0?)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00070a600, {0xeec6e0, 0xc001a49110}, 0xc003195200)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xcec
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00070a600, {0xeec6e0, 0xc001a49110}, 0x0, {0xc000836198, 0x7})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5a0
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3c
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x68
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17230
	/workdir/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xb8

— watchflakes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 1, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 darwin-amd64-longtest tools@d146c601 go@fbfe62bc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 48411 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0051d8de0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xe77fe85?, 0xc00276b670?}, {0xc00276b738?, 0x1d?, 0xdcf3100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc00276b870, 0x1, 0xdcfba1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc000558a00?, 0xc0020498f0?, 0x61?}, {0xe728a15?, 0x3?}, 0x0?, 0x49?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc001c6f980, {0xec11108, 0xc001a75dd0}, 0xc001ed8c60)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc001c6f980, {0xec11108, 0xc001a75dd0}, 0x0, {0xc001d80d20, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 48404
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 18:26 darwin-amd64-longtest tools@c4f958a6 go@fbfe62bc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 44068 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001a709c0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x5dbeb10?, 0xc0005ef670?}, {0xc0005ef738?, 0x1d?, 0x5331100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0005ef870, 0x1, 0x5339a1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc002bf9e80?, 0xc001db86c0?, 0x5f?}, {0x5d67617?, 0x3?}, 0x10?, 0x79?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc001255200, {0x62502c8, 0xc003c8b2f0}, 0xc0039beea0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc001255200, {0x62502c8, 0xc003c8b2f0}, 0x0, {0xc002e3d000, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 43893
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
2023-12-01 21:03 darwin-amd64-longtest tools@58556d12 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 46897 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001c830e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x43dfb50?, 0xc000c61670?}, {0xc000c61738?, 0x1d?, 0x3952100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000c61870, 0x1, 0x395aa1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc003db1180?, 0xc0011ccfc0?, 0x61?}, {0x4388657?, 0x3?}, 0xc0?, 0x3a?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0043c2660, {0x48712c8, 0xc00163d260}, 0xc000262480)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0043c2660, {0x48712c8, 0xc00163d260}, 0x0, {0xc0013347d0, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 46905
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 freebsd-riscv64-unmatched tools@d146c601 go@446a5dcf x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 15059 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0x890ad440, 0x58})
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x3f4
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xb90c1b?, 0x8a1f76c8?}, {0x8a1f7790?, 0x1d?, 0x88d51600?})
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x54
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0x8a1f78c0, 0x1, 0x1?})
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xa18
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0x8a08d080?, 0x89dd6680?, 0x7d?}, {0xb3927f?, 0x3?}, 0x60?, 0xdc?)
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x120
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0x89fdc540, {0xdf2d40, 0x9080b920}, 0x89dcafc0)
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xa60
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0x89fdc540, {0xdf2d40, 0x9080b920}, 0x0, {0x89fbebf8, 0x7})
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x4f8
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x38
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x60
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 15052
	/tmp/workdir-host-freebsd-riscv64-unmatched/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xac

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 aix-ppc64 tools@c4f958a6 go@40f6fbf1 x/tools/gopls/internal/test/integration/completion (log) 
panic: /ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17936 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xa000100011829c0, 0x58})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x504
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x100ada126?, 0xa00010000ddf618?}, {0xa00010000ddf6e0?, 0x1d?, 0x0?})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x58
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xa00010000ddf840, 0x1, 0xa00010000ddf798?})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xb94
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xa0001000404cc00?, 0xa00010000cf5d00?, 0x7a?}, {0x100a827f0?, 0x3?}, 0xa?, 0x0?)
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xa0001000024a540, {0x110216f78, 0xa0001000416fda0}, 0xa00010002046a20)
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xdac
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xa0001000024a540, {0x110216f78, 0xa0001000416fda0}, 0x0, {0xa00010002520148, 0x7})
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x628
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x3c
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x74
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18571
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xc8

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 21:03 darwin-amd64-nocgo tools@58556d12 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17470 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc003467bc0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xd725a15?, 0xc0005c5670?}, {0xc0005c5738?, 0x1d?, 0xcc98500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0005c5870, 0x1, 0xcca0d5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc00345f200?, 0xc0002a9bc0?, 0x5f?}, {0xd6ce577?, 0x3?}, 0xc0?, 0x3d?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0004ea960, {0xdbb62a8, 0xc00482de00}, 0xc00653eb40)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0004ea960, {0xdbb62a8, 0xc00482de00}, 0x0, {0xc0024eb760, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17546
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-13 tools@c4f958a6 go@40f6fbf1 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17672 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0017277a0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x2bf4b50?, 0xc0004d9670?}, {0xc0004d9738?, 0x1d?, 0x2167100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0004d9870, 0x1, 0x216fa1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0055aa680?, 0xc001726ea0?, 0x5f?}, {0x2b9d657?, 0x3?}, 0x90?, 0x75?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00288faa0, {0x30862c8, 0xc002078ae0}, 0xc00339cfc0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00288faa0, {0x30862c8, 0xc002078ae0}, 0x0, {0xc0052a0170, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17657
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 21:03 darwin-amd64-11_0 tools@58556d12 go@77397ffc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17127 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00203a840, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x519
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1c86dbc?, 0x10d74?}, {0xc000671690?, 0x1d?, 0x0?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x2a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000671898, 0x1, 0x100e1e5?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd4a
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc000640180?, 0xc006e3f3e0?, 0x5f?}, {0x1c331ba?, 0x3?}, 0x0?, 0xc2?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x184
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc00acb9f80, {0x1ee0bd8, 0xc0026500c0}, 0xc000168b40)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xf45
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc00acb9f80, {0x1ee0bd8?, 0xc0026500c0}, 0xc0027e2f60?, {0xc00085c2d0, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x62e
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x31
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-longtest tools@c4f958a6 go@67c86037 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 46875 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc001ab6120, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xffdab50?, 0xc001c25670?}, {0xc001c25738?, 0x1d?, 0xf54d100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc001c25870, 0x1, 0xf555a1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004e9ef80?, 0xc001a38ae0?, 0x5f?}, {0xff83657?, 0x3?}, 0xd0?, 0x4f?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc000acd0e0, {0x1046c2c8, 0xc0032a3a40}, 0xc0032747e0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc000acd0e0, {0x1046c2c8, 0xc0032a3a40}, 0x0, {0xc0015a2ec0, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 46906
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-nocgo tools@c4f958a6 go@40f6fbf1 x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18748 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc005ad8d80, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x6f70a15?, 0xc0010a3670?}, {0xc0010a3738?, 0x1d?, 0x64e3500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0010a3870, 0x1, 0x64ebd5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc002864180?, 0xc003275860?, 0x5f?}, {0x6f19577?, 0x3?}, 0xe0?, 0xa0?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc003856b40, {0x74012a8, 0xc000476390}, 0xc002e6e120)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc003856b40, {0x74012a8, 0xc000476390}, 0x0, {0xc001c5e720, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18886
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 18:26 darwin-amd64-nocgo tools@c4f958a6 go@2e6387cb x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18163 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc004b5c2a0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1157f9d5?, 0xc000a6b670?}, {0xc000a6b738?, 0x1d?, 0x10af2500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000a6b870, 0x1, 0x10afad5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc003d26380?, 0xc003a8b560?, 0x5e?}, {0x11528537?, 0x3?}, 0x50?, 0xa5?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc002842f60, {0x11a102a8, 0xc0028909c0}, 0xc00184ac60)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc002842f60, {0x11a102a8, 0xc0028909c0}, 0x0, {0xc003218080, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17647
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 darwin-amd64-12_0 tools@d146c601 go@fbfe62bc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 18056 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc0011a3ec0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0xe9d4e85?, 0xc000e25670?}, {0xc000e25738?, 0x1d?, 0xdf48100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000e25870, 0x1, 0xdf50a1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc004ee6100?, 0xc001d8d500?, 0x5f?}, {0xe97da15?, 0x3?}, 0xe0?, 0xa0?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc000244420, {0xee66108, 0xc003e96390}, 0xc0044e8000)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc000244420, {0xee66108, 0xc003e96390}, 0x0, {0xc0019f6720, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 18036
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 darwin-amd64-nocgo tools@d146c601 go@fbfe62bc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 19158 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc00177fec0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x6302d4a?, 0xc000049670?}, {0xc000049738?, 0x1d?, 0x5876500?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc000049870, 0x1, 0x587ed5e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc002c65000?, 0xc002366f00?, 0x5d?}, {0x62ab935?, 0x3?}, 0x70?, 0xd3?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc003d78cc0, {0x67930c8, 0xc001bdcc00}, 0xc00344e6c0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc003d78cc0, {0x67930c8, 0xc001bdcc00}, 0x0, {0xc001150430, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 19066
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == ""
2023-12-01 16:00 darwin-amd64-11_0 tools@d146c601 go@fbfe62bc x/tools/gopls/internal/test/integration/completion (log) 
panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809: internal error: type checker error -: cannot use _ as value or type not outside its Fset

goroutine 17862 [running]:
golang.org/x/tools/gopls/internal/util/bug.report({0xc002c296e0, 0x58})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:80 +0x514
golang.org/x/tools/gopls/internal/util/bug.Reportf({0x1053fe85?, 0xc0012c3670?}, {0xc0012c3738?, 0x1d?, 0xfab3100?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/util/bug/bug.go:51 +0x25
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics.func1({0xc0012c3870, 0x1, 0xfabba1e?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1809 +0xd51
golang.org/x/tools/gopls/internal/lsp/cache.typeErrorsToDiagnostics(0x0?, {0xc0038c1480?, 0xc000586780?, 0x5f?}, {0x104e8a15?, 0x3?}, 0x10?, 0x87?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1896 +0x18a
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage(0xc0060de660, {0x109d1108, 0xc004a38c30}, 0xc002dbe7e0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:1557 +0xeeb
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage(0xc0060de660, {0x109d1108, 0xc004a38c30}, 0x0, {0xc0025ca170, 0x7})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:554 +0x5e5
golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).forEachPackageInternal.func2()
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:405 +0x2b
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 17847
	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/621876 mentions this issue: gopls/internal/cache: refine bug reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @adonovan @gopherbot @findleyr