Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/counter: preserve prerelease version strings #63619

Closed
hyangah opened this issue Oct 18, 2023 · 1 comment
Closed

x/telemetry/counter: preserve prerelease version strings #63619

hyangah opened this issue Oct 18, 2023 · 1 comment
Assignees
@hyangah
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 18, 2023

Currently the counter package converts version strings with - to devel.
The intention was to handle pseudo-versions (we want them to be devel).
Let's preserve version strings if they don't match pseudo-version pattern (we can reuse/copy the code in x/mod/module.IsPseudoVersion).

cc @golang/tools-team
@gopherbot gopherbot added the telemetry x/telemetry issues label Oct 18, 2023
@gopherbot gopherbot added this to the Unreleased milestone Oct 18, 2023
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 19, 2023
@findleyr findleyr self-assigned this Oct 24, 2023
@findleyr findleyr mentioned this issue Nov 6, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/547878 mentions this issue: internal/counter: preserve programs' prerelease versions

@findleyr findleyr assigned hyangah and unassigned findleyr Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyangah hyangah

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cagedmantis @hyangah @gopherbot @findleyr and others