Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: reset diagnostics when toggling vulncheck on/off #60465

Closed
findleyr opened this issue May 26, 2023 · 1 comment
Closed

x/tools/gopls: reset diagnostics when toggling vulncheck on/off #60465

findleyr opened this issue May 26, 2023 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

Noticed by @hyangah: when toggling vulncheck off, diagnostics do not clear until the user starts typing.

This is yet another case of #42814, but that is too risky a change to make right now.

For this release, a targeted fix.

CC @adonovan
@findleyr findleyr added this to the gopls/v0.12.0 milestone May 26, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 26, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/498560 mentions this issue: gopls/internal/lsp: clear vuln diagnostics on config changes

@golang golang locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr