Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: diagnostics only clear after diagnosticsDelay for edited files #59587

Closed
findleyr opened this issue Apr 12, 2023 · 1 comment
Closed

x/tools/gopls: diagnostics only clear after diagnosticsDelay for edited files #59587

findleyr opened this issue Apr 12, 2023 · 1 comment
Labels
FrozenDueToAge gopls/incremental gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

Reported by @heschi and @ShoshinNikita (in #57987 (comment)), https://go.dev/cl/477979 introduced a bug whereby diagnostics in the current package are not cleared until the diagnosticsDelay expired. Diagnostics should be cleared immediately upon edits.

Fix incoming.
@findleyr findleyr added this to the gopls/v0.12.0 milestone Apr 12, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 12, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/484195 mentions this issue: gopls/internal/lsp: fix initial publication of diagnostics

@golang golang locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls/incremental gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr