Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportConnectionCloseOnRequest failures #57417

Closed
gopherbot opened this issue Dec 20, 2022 · 10 comments
Closed

net/http: TestTransportConnectionCloseOnRequest failures #57417

gopherbot opened this issue Dec 20, 2022 · 10 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Dec 20, 2022 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest" && `saw \d+ unique connections, wanted 1`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.22s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:40617, *net.TCPConn 0x29b7d680" and "127.0.0.1:40618, *net.TCPConn 0x29cc28e0"

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 20, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest"
2022-12-12 14:16 freebsd-arm-paulzhol go@c6ad9dc9 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.22s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:40617, *net.TCPConn 0x29b7d680" and "127.0.0.1:40618, *net.TCPConn 0x29cc28e0"

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest"
2022-11-28 17:25 darwin-amd64-13 go@0f28c478 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.09s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:52552, *net.TCPConn 0xc00009e950" and "127.0.0.1:52566, *net.TCPConn 0xc000404408"
2022-12-08 23:06 freebsd-arm-paulzhol go@e738a2f1 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.07s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:59960, *net.TCPConn 0x29810310" and "127.0.0.1:59965, *net.TCPConn 0x29bdde68"

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest"
2023-01-21 21:08 freebsd-arm-paulzhol go@ba913774 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.41s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:28722, *net.TCPConn 0x299875a0" and "127.0.0.1:28725, *net.TCPConn 0x298100c8"
1 second passes in backend, proxygone= false

— watchflakes

@gopherbot

This comment was marked as off-topic.

Sign in to view
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest"
2023-02-10 21:45 darwin-amd64-race go@8491fd31 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.16s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:53275, *net.TCPConn 0xc000596710" and "127.0.0.1:53278, *net.TCPConn 0xc000196498"

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest"
2023-02-04 07:02 darwin-amd64-13 go@fcff7226 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.09s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:50387, *net.TCPConn 0xc0005a4000" and "127.0.0.1:50403, *net.TCPConn 0xc0005a4030"
2023-02-13 20:18 darwin-amd64-13 go@7f5274a2 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.01s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.08s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:50403, *net.TCPConn 0xc00051c600" and "127.0.0.1:50416, *net.TCPConn 0xc000576670"

— watchflakes

@bcmills bcmills mentioned this issue Apr 7, 2023
Closed
@bcmills bcmills added this to the Backlog milestone Apr 7, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/483116 mentions this issue: net/http: wait forever for write results in tests

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 26, 2023
@dmitshur dmitshur modified the milestones: Backlog, Go1.21 Apr 26, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest" && `saw \d+ unique connections, wanted 1`
2023-09-21 22:22 darwin-amd64-nocgo go@83dce459 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.18s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:50616, *net.TCPConn 0xc0006a04b0" and "127.0.0.1:50623, *net.TCPConn 0xc000012038"

— watchflakes

@gopherbot gopherbot reopened this Oct 5, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnRequest" && `saw \d+ unique connections, wanted 1`
2023-10-10 16:18 freebsd-arm-paulzhol go@e175f27f net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    --- FAIL: TestTransportConnectionCloseOnRequest/h1 (0.51s)
        transport_test.go:306: for Request.Close=false: server saw 2 unique connections, wanted 1

            bodies were: "127.0.0.1:55800, *net.TCPConn 0x299904b0" and "127.0.0.1:55802, *net.TCPConn 0x29989040"

— watchflakes

@dmitshur
Copy link
Contributor

dmitshur commented Oct 26, 2023 •
edited
Loading

Both findings above are on the 1.20 release branch that doesn't have the fix.

@golang golang locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot