Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: cmd/trace: /prototrace endpoint #57159

Open
aktau opened this issue Dec 8, 2022 · 1 comment
Open

proposal: cmd/trace: /prototrace endpoint #57159

aktau opened this issue Dec 8, 2022 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Proposal
Milestone

Comments

@aktau
Copy link
Contributor

aktau commented Dec 8, 2022

Context:

Today, the perfetto UI produced a message I hadn't seen before:

Perfetto UI features are limited for JSON traces. We recommend recording proto-format traces from Chrome.

The docs appear to be: https://perfetto.dev/docs/reference/trace-packet-proto

The trace json output format is fairly verbose, so my hope is that by using proto format we produce more compact files that are easier to ship around and perhaps also lighter weight in the browser. Those extra features they're referencing may be nice too, but I don't know what they are. Currently we cap at 100MiB of JSON data. If we maintain the same cap on proto data (I don't know what the limits of the perfetto UI are) we could represent a larger timeline.

@aktau aktau added the Proposal label Dec 8, 2022
@gopherbot gopherbot added this to the Proposal milestone Dec 8, 2022
@prattmic
Copy link
Member

prattmic commented Dec 8, 2022

I didn't find a canonical issue for migrating to or supporting this web UI, so I'll file this issue that should make using the Perfetto UI easier.

I thought we did have an issue for migrating to a new UI (likely Perfetto), but I can't find it. I was probably thinking of #34374 (comment).

Ironically, I just had an offline discussion the other day about how cmd/trace could potentially provide optional Perfetto output even if we haven't yet completely switched the default UI. We will eventually need to replace the Catapult UI, as it is effectively unmaintained and will eventually break again similar to #34374.

cc @golang/runtime @mknyszek @felixge @nsrip-dd

@prattmic prattmic added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 8, 2022
@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Proposal
Projects
Status: No status
Status: Incoming
Development

No branches or pull requests

3 participants