os: kill process failed in the windows

[gopherbot]

by runner.mei:

What steps will reproduce the problem?

kill process failed in the windows

What is the expected output?

"TerminateProcess: Access is denied."

What do you see instead?

kill process success in the windows

Which operating system are you using?

windows

Which version are you using?  (run 'go version')

go version go1.1 windows/amd64

Please provide any additional information below.

// unit test
func TestKillProcess(t *testing.T) {
    pr := exec.Command("ping", "127.0.0.1", "-t")
    e := pr.Start()
    if nil != e {
        t.Error(e)
        return
    }
    kp, _ := os.FindProcess(pr.Process.Pid)
    e = kp.Kill()

    if nil != e {
        t.Error(e)
        pr.Process.Kill()
        return
    }
}
/// --- FAIL: TestKillProcess (0.06 seconds)
///        kill_windows_test.go:20: TerminateProcess: Access is denied.
/// FAIL
/// exit status 1
/// FAIL    daemon  45.852s


PATCH
// src/pkg/os/exec_windows.go
71a72
>    const PROCESS_TERMINATE = 0x0001
73c74
<        syscall.PROCESS_QUERY_INFORMATION | syscall.SYNCHRONIZE

---
>        syscall.PROCESS_QUERY_INFORMATION | syscall.SYNCHRONIZE | PROCESS_TERMINATE

[alexbrainman]

Comment 1:

I am not sure about changing this. The fix will require additional authority (ability to
kill the process) for everyone who uses this api. So the api calls that use to work in
the past might fall after we change that. It is unfortunate.
Perhaps we could change (*Process).signal to try and open process again with ... +
PROCESS_TERMINATE attribute just for the syscall.TerminateProcess.
Leaving for others to decide.
Alex

Labels changed: added os-windows.

[rsc]

Comment 3:

Does it work if you get the handle from StartProcess instead of FindProcess?

[gopherbot]

Comment 4 by runner.mei:

if I get the handle from StartProcess instead of FindProcess, it should work.

[gopherbot]

Comment 5 by runner.mei:

if I get the handle from StartProcess instead of FindProcess, it is ok

[alexbrainman]

Comment 6:

That is expected - if you start process, you get permission to kill it by default.
I think, if there are no objections, I will try to do what I suggested in #1. I won't be
able to try for a few days.
Alex

Status changed to Accepted.

[alexbrainman]

Comment 7:

How about this https://golang.org/cl/9651047/ ?
Alex

Status changed to Started.

[alexbrainman]

Comment 8:

This issue was closed by revision 9b2561e.

Status changed to Fixed.