Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: add mod vendor -check #43706

Closed
fishy opened this issue Jan 14, 2021 · 2 comments
Closed

cmd/go: add mod vendor -check #43706

fishy opened this issue Jan 14, 2021 · 2 comments

Comments

@fishy
Copy link

fishy commented Jan 14, 2021

Very similar to #27005, I think a go mod vendor -check that returns non-zero when it would make any changes to vendor/ directory would be useful in pre-commit hooks and CIs.

Things that could be different from go mod tidy -check are:

  1. Unlike go mod tidy -check, this likely requires network access to work
  2. This might be more go version dependent? I think the vendor/modules.txt file are different between 1.15 and 1.14, not sure if this will cause problems with proposed go mod vendor -check.
@bcmills
Copy link
Contributor

bcmills commented Jan 15, 2021

Duplicate of #27348?

@fishy
Copy link
Author

fishy commented Jan 15, 2021

Yea I think #27348 pretty much covered it 👍

@fishy fishy closed this as completed Jan 15, 2021
@golang golang locked and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants