-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: ICE on invalid conversion of untyped expression #33308
Comments
@mdempsky CL 187657 seems to fix this issue already, go tip now reports:
|
@cuonglm Interesting, thanks for pointing that out. |
Unless I've misunderstood the discussion above, it seems that this issue can be closed, since the crash on the reproducer is now fixed. @mdempsky is that correct? |
@ALTree I think so. A regress test would be good though. |
Change https://golang.org/cl/243458 mentions this issue: |
Oops, I thought tree was already unlocked for the next release cycle. I think a simple regress test should be fine though. |
cmd/compile panics with an ICE on this (invalid) input:
For comparison, go/types emits
cannot convert (1 << v) + 1 (untyped int value) to []byte
, while gccgo emitsinvalid context-determined non-integer type for left operand of shift
.Self-assigning for now since I'm working on CL 187657, which doesn't currently fix this, but I expect can easily be made to.
The text was updated successfully, but these errors were encountered: