Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text/message/pipeline: TestFullCycle missing a Skip if the go command cannot be executed #32844

Closed
bcmills opened this issue Jun 28, 2019 · 2 comments
Closed

x/text/message/pipeline: TestFullCycle missing a Skip if the go command cannot be executed #32844

bcmills opened this issue Jun 28, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 28, 2019

golang.org/x/text/message/pipeline.TestFullCycle is persistently failing on the illumos-amd64-joyent and js-wasm builders, apparently due to the inability to execute the go command as a subprocess.

The test should probably use exec.LookPath to explicitly check for a go binary, and should call t.Skip instead of failing if the binary is not available.
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 28, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jun 28, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Jun 28, 2019

Examples:
https://build.golang.org/log/ce65edc1bcee1f8f724055baf991a61ef5df7f88
https://build.golang.org/log/5433aa404836604f7e4add64ad85dff3d4f3e818

@bcmills bcmills mentioned this issue Jun 28, 2019
Open
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/192325 mentions this issue: message/pipeline: skip test if the 'go' executable is not found

@golang golang locked and limited conversation to collaborators Aug 28, 2020
@rsc rsc unassigned mpvl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @mpvl @gopherbot