Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/imports: return only import changes #31493

Closed
stamblerre opened this issue Apr 16, 2019 · 1 comment
Closed

x/tools/imports: return only import changes #31493

stamblerre opened this issue Apr 16, 2019 · 1 comment
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

imports.Process returns the entire updated file contents, but it would also be helpful if it could return the diff specifically between old and new import blocks. The context for this is gopls, which has a distinction between formatting and organizing imports.
@stamblerre stamblerre added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Apr 16, 2019
@gopherbot gopherbot added this to the Unreleased milestone Apr 16, 2019
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 28, 2019
@stamblerre
Copy link
Contributor Author

Duplicate of #30843

@stamblerre stamblerre marked this as a duplicate of #30843 Aug 28, 2019
@golang golang locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @stamblerre @gopherbot