Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/dl: store the list of validUsers in a more dynamic way #29898

Open
julieqiu opened this issue Jan 23, 2019 · 4 comments
Open
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@julieqiu
Copy link
Member

The list of validUsers is hardcoded at https://github.com/golang/tools/blob/master/godoc/dl/dl.go#L317. This means that every time someone is doing a release for a first time, we need to make a CL to add them to this list (so that they can run the release command) and redeploy golang.org.

We may want to store this list in a more dynamic way.

@gopherbot gopherbot added this to the Unreleased milestone Jan 23, 2019
@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 23, 2019
@julieqiu
Copy link
Member Author

/cc @bradfitz

@bradfitz
Copy link
Contributor

we need to make a CL to add them to this list (so that they can run the release command) and redeploy golang.org

And cherry-pick it to the release branch, IIRC? /cc @dmitshur

Potential places to store this info:

  • GCE metadata
  • GCS text/json file
  • ... ?

I think GCE metadata is my vote.

@bradfitz
Copy link
Contributor

Or we don't use the gomote-style user authentication and instead use OAuth2-authenticated requests and then check some IAM permission.

/cc @FiloSottile

@dmitshur
Copy link
Contributor

And cherry-pick it to the release branch, IIRC? /cc @dmitshur

Yes, and then deploy golang.org. This becomes simpler after #29206 is done.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@dmitshur dmitshur changed the title x/tools/godoc/dl: store the list of validUsers in a more dynamic way x/website/internal/dl: store the list of validUsers in a more dynamic way Mar 25, 2020
@dmitshur dmitshur removed the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants