cmd/go/internal/work: golang fails to parse pkgonfig 1.4+ output

[jcajka]

What version of Go are you using (go version)?

1.10beta1

Does this issue reproduce with the latest release?

yes, AFAIK this affects all supported versions, IMHO backport to all of them would be appropriate

What operating system and processor architecture are you using (go env)?

linux/*

What did you do?

Run test suite on linux system with most recent pkgconfig(1.4+) installed.

What did you expect to see?

Tests to pass.

What did you see instead?

ok  	cmd/fix	0.025s
--- FAIL: TestCgoPkgConfig (0.20s)
	go_test.go:310: running testgo [env PKG_CONFIG]
	go_test.go:319: standard output:
	go_test.go:320: pkg-config
		
	go_test.go:310: running testgo [run /tmp/gotest291662432/foo.go]
	go_test.go:323: standard error:
	go_test.go:324: # command-line-arguments
		gcc: error: '-DDEFINED_FROM_PKG_CONFIG=hello: No such file or directory
		gcc: error: world': No such file or directory
		
	go_test.go:333: go [run /tmp/gotest291662432/foo.go] failed unexpectedly: exit status 2
FAIL
FAIL	cmd/go	39.947s
ok  	cmd/go/internal/generate	0.021s

FYI CL fixing this is on the way

[gopherbot]

Change https://golang.org/cl/86541 mentions this issue: cmd/go/internal/work : improve pkgconfig support to work with latest pkgconf