Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: deduping of panicindex calls on the same line appears broken #20332

Closed
josharian opened this issue May 11, 2017 · 3 comments
Closed

cmd/compile: deduping of panicindex calls on the same line appears broken #20332

josharian opened this issue May 11, 2017 · 3 comments
Labels
FrozenDueToAge Performance
Milestone
Go1.9

Comments

@josharian
Copy link
Contributor

Run go tool compile -S fannkuch_test.go 2>&1 | grep -c "CALL.*panicindex". This yields 9 on 1.8.1 and 13 on tip. It appears that the panicindex-on-same-line deduping is broken; the extra panicindex calls are all duplicates. Tip output:

	0x00ef 00239 (fannkuch_test.go:23)	CALL	runtime.panicindex(SB)
	0x0130 00304 (fannkuch_test.go:34)	CALL	runtime.panicindex(SB)
	0x0191 00401 (fannkuch_test.go:40)	CALL	runtime.panicindex(SB)
	0x0198 00408 (fannkuch_test.go:40)	CALL	runtime.panicindex(SB)
	0x01ed 00493 (fannkuch_test.go:45)	CALL	runtime.panicindex(SB)
	0x01f4 00500 (fannkuch_test.go:45)	CALL	runtime.panicindex(SB)
	0x026d 00621 (fannkuch_test.go:65)	CALL	runtime.panicindex(SB)
	0x0274 00628 (fannkuch_test.go:65)	CALL	runtime.panicindex(SB)
	0x02d4 00724 (fannkuch_test.go:68)	CALL	runtime.panicindex(SB)
	0x02db 00731 (fannkuch_test.go:67)	CALL	runtime.panicindex(SB)
	0x02e7 00743 (fannkuch_test.go:49)	CALL	runtime.panicindex(SB)
	0x02fd 00765 (fannkuch_test.go:37)	CALL	runtime.panicindex(SB)
	0x0313 00787 (fannkuch_test.go:37)	CALL	runtime.panicindex(SB)
@josharian josharian added this to the Go1.9 milestone May 11, 2017
@josharian josharian self-assigned this May 11, 2017
@josharian josharian mentioned this issue May 11, 2017
Open
@dr2chase
Copy link
Contributor

Is this perhaps an artifact of enhanced positions that are now more than just a line?

@josharian
Copy link
Contributor Author

Probably, yes. Haven't dug yet, but plan to today.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/43291 mentions this issue.

@golang golang locked and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Performance
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@josharian @dr2chase @gopherbot