Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context: TestLayersCancel flake #19459

Open
bradfitz opened this issue Mar 8, 2017 · 5 comments
Open

context: TestLayersCancel flake #19459

bradfitz opened this issue Mar 8, 2017 · 5 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Mar 8, 2017 •
edited
Loading

From trybot run https://storage.googleapis.com/go-build-log/dbcdd62f/openbsd-amd64-60_97787251.log

--- FAIL: TestLayersCancel (0.46s)
	context_test.go:520: seed=1488986705610226342: ctx should not be canceled yet
	context_test.go:565: context.Background.WithCancel.WithDeadline(2017-03-08 07:25:05.810276628 -0800 PST m=+1.147363981 [-255.077111ms]).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc4200155b0), (*context.value)(0xc4200155b0)).WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc4200155b8), (*context.value)(0xc4200155b8)).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc420015660), (*context.value)(0xc420015660)).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc420015668), (*context.value)(0xc420015668)).WithValue((*context.value)(0xc4200156d0), (*context.value)(0xc4200156d0)).WithCancel.WithCancel.WithCancel
FAIL
FAIL	context	1.745s
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. labels Mar 8, 2017
@bradfitz bradfitz added this to the Go1.9 milestone Mar 8, 2017
@josharian
Copy link
Contributor

I ran a stress test of just that test and got to 100k runs with no failure. Switching to a stress test of all package context tests. On darwin/amd64. Will report back.

@bradfitz
Copy link
Contributor Author

Did you try seed=1488986705610226342?

@josharian
Copy link
Contributor

No. :)

Got to 20k runs of all context tests without that seed. Added the seed, trying again. Hasn't failed immediately.

@josharian
Copy link
Contributor

josharian commented Mar 10, 2017 •
edited
Loading

1.5 million runs with that seed, no failures. I give up. Maybe (waves hands) it has something to do with openbsd and signals/sleeps/etc. (like #17712 or, um, something)?

@bradfitz
Copy link
Contributor Author

bradfitz commented Jun 8, 2017

Okay, punting to Unreleased for now until we see it again.

@bradfitz bradfitz modified the milestones: Unreleased, Go1.9 Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bradfitz @josharian