Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/asm: support file-scoped symbols #19277

Closed
josharian opened this issue Feb 24, 2017 · 4 comments
Closed

cmd/asm: support file-scoped symbols #19277

josharian opened this issue Feb 24, 2017 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@josharian
Copy link
Contributor

See #18225 for history and discussion. Once completed, roll back part of CL 34284.

@josharian josharian added this to the Go1.9 milestone Feb 24, 2017
@mwhudson
Copy link
Contributor

I think this would require making cmd/internal/obj support more values for LSym.Version than just 0 and 1. Probably the approach used by the linker would work OK (having an array of LSym maps indexed by version). Some linker changes would also be required, it currently assumes each object file only consumes one potential value for version. Nothing that can't be changed, but not completely trivial.

@josharian
Copy link
Contributor Author

Could this be done instead with some name mangling?

@mwhudson
Copy link
Contributor

mwhudson commented May 7, 2017

Yes probably

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9 Jun 26, 2017
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jun 26, 2017
@rsc
Copy link
Contributor

rsc commented Nov 22, 2017

If we want to allow the assembler to process multiple files then we would need to do this.
But I don't think it's particularly important for the assembler to process multiple files:
it is fine to continue to call it once per file, and then this bug, and all other similar
bugs where files are not treated truly independently, will be impossible.
That really seems like the best strategy.
Having any assembly files is rare; having many is even rarer. Not worth the trouble.

@rsc rsc closed this as completed Nov 22, 2017
@golang golang locked and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants