cmd/compile: remove stack check for leaf routines

[randall77]

func add64(a, b int) int {
	x := a + b
	return x
}

There's no need for a stack check for this function.
386 and arm64 emit a stack check anyway. Those should be eliminated.

See #8474

[mundaym]

#13379 (automatic nosplit) is related to this. Are you sure 386 is affected? I thought cmd/internal/obj/x86 automatically marked functions with small stack frames as nosplit.

[mdempsky]

386 looks affected to me:

$ cat add64.go
package p

func Add64(a, b int) int {
	x := a + b
	return x
}

$ GOARCH=386 go tool compile -S add64.go | grep add64.go:
	0x0000 00000 (add64.go:3)	TEXT	"".Add64(SB), $0-12
	0x0000 00000 (add64.go:3)	MOVL	TLS, CX
	0x0007 00007 (add64.go:3)	MOVL	(CX)(TLS*2), CX
	0x000d 00013 (add64.go:3)	CMPL	SP, 8(CX)
	0x0010 00016 (add64.go:3)	JLS	33
	0x0012 00018 (add64.go:3)	FUNCDATA	$0, gclocals·54241e171da8af6ae173d69da0236748(SB)
	0x0012 00018 (add64.go:3)	FUNCDATA	$1, gclocals·33cdeccccebe80329f1fdbee7f5874cb(SB)
	0x0012 00018 (add64.go:4)	MOVL	"".b+8(FP), AX
	0x0016 00022 (add64.go:4)	MOVL	"".a+4(FP), CX
	0x001a 00026 (add64.go:4)	ADDL	CX, AX
	0x001c 00028 (add64.go:5)	MOVL	AX, "".~r2+12(FP)
	0x0020 00032 (add64.go:5)	RET
	0x0021 00033 (add64.go:5)	NOP
	0x0021 00033 (add64.go:3)	PCDATA	$0, $-1
	0x0021 00033 (add64.go:3)	CALL	runtime.morestack_noctxt(SB)
	0x0026 00038 (add64.go:3)	JMP	0

$ GOARCH=amd64 go tool compile -S add64.go | grep add64.go:
	0x0000 00000 (add64.go:3)	TEXT	"".Add64(SB), $0-24
	0x0000 00000 (add64.go:3)	FUNCDATA	$0, gclocals·54241e171da8af6ae173d69da0236748(SB)
	0x0000 00000 (add64.go:3)	FUNCDATA	$1, gclocals·33cdeccccebe80329f1fdbee7f5874cb(SB)
	0x0000 00000 (add64.go:4)	MOVQ	"".b+16(FP), AX
	0x0005 00005 (add64.go:4)	MOVQ	"".a+8(FP), CX
	0x000a 00010 (add64.go:4)	ADDQ	CX, AX
	0x000d 00013 (add64.go:5)	MOVQ	AX, "".~r2+24(FP)
	0x0012 00018 (add64.go:5)	RET

[randall77]

This issue is definitely related to #13379, not sure if it is a dup or not.

[mundaym]

Ah yes, the relevant x86 code only automatically applies nosplit when the pointer size is 64-bits.

// TODO(rsc): Remove 'p.Mode == 64 &&'.
if p.Mode == 64 && autoffset < obj.StackSmall && p.From3Offset()&obj.NOSPLIT == 0 {

go/src/cmd/internal/obj/x86/obj6.go

Line 673 in 3a067cc

if p.Mode == 64 && autoffset < obj.StackSmall && p.From3Offset()&obj.NOSPLIT == 0 {

[randall77]

I'm going to close this issue. We do remove the stack check for leaf routines on amd64.
Let's use #13379 for implementing this on other architectures (including 386).