Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: reenable bad pointer check in GC #10591

Closed
rsc opened this issue Apr 28, 2015 · 1 comment
Closed

runtime: reenable bad pointer check in GC #10591

rsc opened this issue Apr 28, 2015 · 1 comment
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Apr 28, 2015

runtime/mbitmap.go says:

    // The following ensures that we are rigorous about what data
    // structures hold valid pointers.
    // TODO(rsc): Check if this still happens.
    if false {
        // Still happens sometimes. We don't know why.
        printlock()
        print("runtime:objectstart Span weird: p=", hex(p), " k=", hex(k))
        if s == nil {
            print(" s=nil\n")
        } else {
            print(" s.start=", hex(s.start<<_PageShift), " s.limit=", hex(s.limit), " s.state=", s.state, "\n")
        }
        printunlock()
        throw("objectstart: bad pointer in unexpected span")
    }

This needs to happen for Go 1.5.
We broke a lot of programs in Go 1.4 by insisting on this
(for good reasons), and we don't want relapses during Go 1.5.

@rsc rsc self-assigned this Apr 28, 2015
@rsc rsc added this to the Go1.5 milestone Apr 28, 2015
@aclements
Copy link
Member

Duplicate of #9880.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants