From 53115b4860046f0f8afa31319b31eb63aa93a626 Mon Sep 17 00:00:00 2001 From: komuw Date: Fri, 24 Aug 2018 16:45:28 +0300 Subject: [PATCH] runtime/pprof: document labels bug Currently only CPU profile utilizes tag information. This change documents that fact --- src/runtime/pprof/label.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/runtime/pprof/label.go b/src/runtime/pprof/label.go index 35647ee3ce1f21..4ad7a901cd19b7 100644 --- a/src/runtime/pprof/label.go +++ b/src/runtime/pprof/label.go @@ -54,6 +54,8 @@ func WithLabels(ctx context.Context, labels LabelSet) context.Context { // Labels takes an even number of strings representing key-value pairs // and makes a LabelSet containing them. // A label overwrites a prior label with the same key. +// BUG(hyangah): Currently only CPU profile utilizes labels information.. +// See https://github.com/golang/go/issues/23458 for details. func Labels(args ...string) LabelSet { if len(args)%2 != 0 { panic("uneven number of arguments to pprof.Labels")