From 3ba6387bd09d8dd67d04e16725a9a0ffab78756b Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Mon, 18 May 2015 11:09:29 -0700 Subject: [PATCH] test: re-enable rotate tests Memory usage has been reduced. The tests are still slow, but that is issue #10571. /usr/bin/time shows significant variation in the peak memory usage compiling with tip. This is unsurprising, given GC. Using Go 1.4.2, memory is stable at 410mb. Using tip at d2ee09298, memory ranges from 470mb (+15%) to 534mb (+30%), with a mean of 504mb (+23%), with n=50. Fixes #9933. Change-Id: Id31f3ae086ec324abf70e8f1a8044c4a0c27e274 Reviewed-on: https://go-review.googlesource.com/10211 Reviewed-by: Brad Fitzpatrick --- test/rotate0.go | 2 -- test/rotate1.go | 2 -- test/rotate2.go | 2 -- test/rotate3.go | 2 -- 4 files changed, 8 deletions(-) diff --git a/test/rotate0.go b/test/rotate0.go index 9c4f560f748b3..400b225cf7b99 100644 --- a/test/rotate0.go +++ b/test/rotate0.go @@ -1,5 +1,3 @@ -// skip - // runoutput ./rotate.go // Copyright 2013 The Go Authors. All rights reserved. diff --git a/test/rotate1.go b/test/rotate1.go index 2d9b797922867..98b0b1c849ea1 100644 --- a/test/rotate1.go +++ b/test/rotate1.go @@ -1,5 +1,3 @@ -// skip - // runoutput ./rotate.go // Copyright 2013 The Go Authors. All rights reserved. diff --git a/test/rotate2.go b/test/rotate2.go index 90446253127a9..c50f8ce73bd30 100644 --- a/test/rotate2.go +++ b/test/rotate2.go @@ -1,5 +1,3 @@ -// skip - // runoutput ./rotate.go // Copyright 2013 The Go Authors. All rights reserved. diff --git a/test/rotate3.go b/test/rotate3.go index b6b71c8b47e49..73d47d8524c95 100644 --- a/test/rotate3.go +++ b/test/rotate3.go @@ -1,5 +1,3 @@ -// skip - // runoutput ./rotate.go // Copyright 2013 The Go Authors. All rights reserved.