From 08725f9de28726b52c2e62a37cd378d10f10c110 Mon Sep 17 00:00:00 2001 From: Filippo Valsorda Date: Fri, 13 Dec 2024 17:16:44 +0100 Subject: [PATCH] crypto/internal/cryptotest: skip TestAllocations on s390x TestXAESAllocations fails like #70448, and crypto/rand's fails in FIPS mode. We can't keep chasing these without even a LUCI builder. Updates #67307 Change-Id: I5d0edddf470180a321dec55cabfb018db62eb940 Reviewed-on: https://go-review.googlesource.com/c/go/+/636055 Auto-Submit: Filippo Valsorda Reviewed-by: Roland Shoemaker LUCI-TryBot-Result: Go LUCI Reviewed-by: Carlos Amedee --- src/crypto/internal/cryptotest/allocations.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/crypto/internal/cryptotest/allocations.go b/src/crypto/internal/cryptotest/allocations.go index 0194c2f89dc77e..70055af70b42ec 100644 --- a/src/crypto/internal/cryptotest/allocations.go +++ b/src/crypto/internal/cryptotest/allocations.go @@ -32,6 +32,12 @@ func SkipTestAllocations(t *testing.T) { t.Skip("skipping allocations test on plan9") } + // s390x deviates from other assembly implementations and is very hard to + // test due to the lack of LUCI builders. See #67307. + if runtime.GOARCH == "s390x" { + t.Skip("skipping allocations test on s390x") + } + // Some APIs rely on inliner and devirtualization to allocate on the stack. testenv.SkipIfOptimizationOff(t) }