Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Prefetch direct dependencies during init #1144

Closed
carolynvs opened this issue Sep 9, 2017 · 2 comments · Fixed by #1176
Closed

Prefetch direct dependencies during init #1144

carolynvs opened this issue Sep 9, 2017 · 2 comments · Fixed by #1176

Comments

@carolynvs
Copy link
Collaborator

The initial caching of the repositories can be slow, and doesn't print any output because it's happening as a side-effect of the other init logic. We used to explicitly prefetch the repositories and log a message, but that was lost at some point over the past months.

https://github.com/golang/dep/pull/194/files#diff-b14a2eb16f1efbc6aa9f1ffdad724265R241

Let's start doing this again during init (most likely in getDirectDependencies), and cap the concurrency at 4.

Original comment that inspired this issue: #1129 (comment).

@sdboyer
Copy link
Member

sdboyer commented Sep 12, 2017

note that an impl of this should almost certainly use golang.org/x/sync/errgroup, which we'll be introducing in #1155

@xmattstrongx
Copy link
Contributor

@carolynvs I can pick this up. I worked on the original log message story after all 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants