Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Multiple constraints with the same source do not work #1105

Closed
akutz opened this issue Aug 31, 2017 · 2 comments · Fixed by #1132
Closed

Multiple constraints with the same source do not work #1105

akutz opened this issue Aug 31, 2017 · 2 comments · Fixed by #1132

Comments

@akutz
Copy link
Contributor

akutz commented Aug 31, 2017

Dep Version

v0.3.0, darwin-amd64 - Downloaded from GitHub releases page

What dep command did you run?

$ dep ensure

What did you expect to see?

A lock file that reflected the contents of the toml file.

What did you see instead?

A lock file that did not respect the contents of the toml file. What happened was I had the following constraints in the toml file:

[[constraint]]
  name = "gopkg.in/yaml.v1"
  source = "https://github.com/akutz/yaml.git"
  revision = "bc35f417f8a7664a73d46c9def2933417c03019f"
[[constraint]]
  name = "gopkg.in/yaml.v2"
  source = "https://github.com/akutz/yaml.git"
  revision = "bc35f417f8a7664a73d46c9def2933417c03019f"

But in the lock file only the yaml.v1 package was using my fork as its source. The yaml.v2 package was pointing to its primary repo.

It appears dep does not tolerate multiple packages with the same source.

@sdboyer sdboyer added the bug label Sep 4, 2017
@sdboyer
Copy link
Member

sdboyer commented Sep 4, 2017

yeah this seems super weird - we'll need to start in on this with some test cases.

@sdboyer
Copy link
Member

sdboyer commented Sep 6, 2017

turns out, this is the same problem as in #1119 (i think). it's not that multiple instances of the same source field don't work, just that multiple of gopkg.in at different path-versions weren't separating correctly. i have a PR that should fix this, but it'd be great if you could test it out and verify!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants