-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented breaking change in migrate/migrate Docker image #625
Labels
backwards incompatible
Change is backwards incompatible
Comments
Nice catch, thank you for reporting! I'm thinking about a quick fix for this in |
For the time being, I updated the release notes with the breaking change! Thanks again for the report! |
kodiakhq bot
referenced
this issue
in cloudquery/cloudquery
Jun 20, 2022
…5.2 (#928) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-migrate/migrate/v4](https://togithub.com/golang-migrate/migrate) | require | patch | `v4.15.0` -> `v4.15.2` | --- ### Release Notes <details> <summary>golang-migrate/migrate</summary> ### [`v4.15.2`](https://togithub.com/golang-migrate/migrate/releases/tag/v4.15.2) [Compare Source](https://togithub.com/golang-migrate/migrate/compare/v4.15.1...v4.15.2) #### Changes ##### Documentation - [`06c25a2`](https://togithub.com/golang-migrate/migrate/commit/06c25a2) Add pkger to README (by [@​glacials](https://togithub.com/glacials) ) - [`ed8a8b0`](https://togithub.com/golang-migrate/migrate/commit/ed8a8b0) Include iofs in migration sources (by [@​bndw](https://togithub.com/bndw) ) - [`b69b032`](https://togithub.com/golang-migrate/migrate/commit/b69b032) clarify the package name ([#​660](https://togithub.com/golang-migrate/migrate/issues/660)) (by [@​khash](https://togithub.com/khash) ) - [`bfd0502`](https://togithub.com/golang-migrate/migrate/commit/bfd0502) Set syntax highlighting for pkger example (by [@​glacials](https://togithub.com/glacials) ) - [`81cbc9c`](https://togithub.com/golang-migrate/migrate/commit/81cbc9c) fix: incorrect clickhouse dns example (by [@​xkisu](https://togithub.com/xkisu) ) ##### Database Drivers - [`f621644`](https://togithub.com/golang-migrate/migrate/commit/f621644) Add WithConnection to Postgres similar to MySQL. (by [@​AndreasKl](https://togithub.com/AndreasKl) ) - [`6e499cb`](https://togithub.com/golang-migrate/migrate/commit/6e499cb) Expose configuring cassandra connect timeout through query string (by [@​taywrobel](https://togithub.com/taywrobel) ) - [`4ba6957`](https://togithub.com/golang-migrate/migrate/commit/4ba6957) Resolves [#​647](https://togithub.com/golang-migrate/migrate/issues/647) - Fixes typos in Mongo advisory locking parameters ([#​648](https://togithub.com/golang-migrate/migrate/issues/648)) (by [@​SJrX](https://togithub.com/SJrX) ) - [`9d3babd`](https://togithub.com/golang-migrate/migrate/commit/9d3babd) Run SQL server tests on Azure SQL Edge (by [@​jfhbrook-at-work](https://togithub.com/jfhbrook-at-work) ) - [`5798784`](https://togithub.com/golang-migrate/migrate/commit/5798784) Update Spanner to 1.27 (by [@​mccalltd](https://togithub.com/mccalltd) ) - [`020eda4`](https://togithub.com/golang-migrate/migrate/commit/020eda4) Upgrade cloud.google.com/go/spanner to 1.28.0, which adds JSON_VALUE support (by [@​kylechadha](https://togithub.com/kylechadha) ) - [`9f5ed82`](https://togithub.com/golang-migrate/migrate/commit/9f5ed82) Use DELETE FROM instead of TRUNCATE for MySQL ([#​656](https://togithub.com/golang-migrate/migrate/issues/656)) (by [@​martinarrieta](https://togithub.com/martinarrieta) and [@​antigremlin](https://togithub.com/antigremlin) ) - [`608e4f6`](https://togithub.com/golang-migrate/migrate/commit/608e4f6) Use the recommended v4 in mysql README (by [@​mgenware](https://togithub.com/mgenware) ) - [`a46677e`](https://togithub.com/golang-migrate/migrate/commit/a46677e) bump go-sqlite3 to v1.14.10 (by [@​pankona](https://togithub.com/pankona) ) ##### Migration Sources - [`a2b0bda`](https://togithub.com/golang-migrate/migrate/commit/a2b0bda) change github auth to use oauth token instead of basic. (by [@​Greyeye](https://togithub.com/Greyeye) ) ##### Builds - [`5aa1a03`](https://togithub.com/golang-migrate/migrate/commit/5aa1a03) Bump version of autorest/adal (by [@​jcmuller](https://togithub.com/jcmuller) ) - [`169d0fc`](https://togithub.com/golang-migrate/migrate/commit/169d0fc) Include 2 letter query param key in unit test (by [@​suzaku](https://togithub.com/suzaku) ) - [`331a15d`](https://togithub.com/golang-migrate/migrate/commit/331a15d) Update dktest from v0.3.9 to v0.3.10 to fix upstream security issues (by [@​dhui](https://togithub.com/dhui) ) - [`c277388`](https://togithub.com/golang-migrate/migrate/commit/c277388) Update dktest to v0.3.9 for upstream security vulnerability fixes (by [@​dhui](https://togithub.com/dhui) ) - [`cf68462`](https://togithub.com/golang-migrate/migrate/commit/cf68462) Run gofmt on internal build dir (by [@​dhui](https://togithub.com/dhui) ) - [`fc7f720`](https://togithub.com/golang-migrate/migrate/commit/fc7f720) refactor: use sort.Slice (by [@​suzaku](https://togithub.com/suzaku) ) - [`918e13a`](https://togithub.com/golang-migrate/migrate/commit/918e13a) Upgrade containerd and image-spec for the vulnerabilities ([#​662](https://togithub.com/golang-migrate/migrate/issues/662)) (by [@​mopp](https://togithub.com/mopp) ) - [`4f82413`](https://togithub.com/golang-migrate/migrate/commit/4f82413) len(k) is guaranteed to be greater than 1 in this case (by [@​suzaku](https://togithub.com/suzaku) ) Thank you for your hard work and all your contributions! ### [`v4.15.1`](https://togithub.com/golang-migrate/migrate/releases/tag/v4.15.1) [Compare Source](https://togithub.com/golang-migrate/migrate/compare/v4.15.0...v4.15.1) #### Changes ##### Database Drivers - Update gosnowflake from v1.4.3 to v1.6.3 to fix security warnings ([#​632](https://togithub.com/golang-migrate/migrate/issues/632) & [#​637](https://togithub.com/golang-migrate/migrate/issues/637)). Thanks [@​nicholas-mainardi](https://togithub.com/nicholas-mainardi) and [@​obitech](https://togithub.com/obitech) for reporting the issue! - Add unofficial support for AWS Keyspaces to the Cassandra DB driver by `DELETE`ing the schema version table instead of using `TRUNCATE` thanks to [@​florentsolt](https://togithub.com/florentsolt) and [@​Baumanar](https://togithub.com/Baumanar) ([#​634](https://togithub.com/golang-migrate/migrate/issues/634)) ##### Docker Image - Fixed CLI binary file location ([https://github.com/golang-migrate/migrate/issues/625](https://togithub.com/golang-migrate/migrate/issues/625)) thanks to [@​Fontinalis](https://togithub.com/Fontinalis) ([https://github.com/golang-migrate/migrate/pull/628](https://togithub.com/golang-migrate/migrate/pull/628)) ##### Builds - Update dktest to v0.3.7 to fix security warnings ([#​632](https://togithub.com/golang-migrate/migrate/issues/632)). Thanks [@​nicholas-mainardi](https://togithub.com/nicholas-mainardi) for reporting the issue! </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
kodiakhq bot
referenced
this issue
in cloudquery/cq-provider-sdk
Jun 20, 2022
…5.2 (#348) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-migrate/migrate/v4](https://togithub.com/golang-migrate/migrate) | require | patch | `v4.15.0` -> `v4.15.2` | --- ### Release Notes <details> <summary>golang-migrate/migrate</summary> ### [`v4.15.2`](https://togithub.com/golang-migrate/migrate/releases/tag/v4.15.2) [Compare Source](https://togithub.com/golang-migrate/migrate/compare/v4.15.1...v4.15.2) #### Changes ##### Documentation - [`06c25a2`](https://togithub.com/golang-migrate/migrate/commit/06c25a2) Add pkger to README (by [@​glacials](https://togithub.com/glacials) ) - [`ed8a8b0`](https://togithub.com/golang-migrate/migrate/commit/ed8a8b0) Include iofs in migration sources (by [@​bndw](https://togithub.com/bndw) ) - [`b69b032`](https://togithub.com/golang-migrate/migrate/commit/b69b032) clarify the package name ([#​660](https://togithub.com/golang-migrate/migrate/issues/660)) (by [@​khash](https://togithub.com/khash) ) - [`bfd0502`](https://togithub.com/golang-migrate/migrate/commit/bfd0502) Set syntax highlighting for pkger example (by [@​glacials](https://togithub.com/glacials) ) - [`81cbc9c`](https://togithub.com/golang-migrate/migrate/commit/81cbc9c) fix: incorrect clickhouse dns example (by [@​xkisu](https://togithub.com/xkisu) ) ##### Database Drivers - [`f621644`](https://togithub.com/golang-migrate/migrate/commit/f621644) Add WithConnection to Postgres similar to MySQL. (by [@​AndreasKl](https://togithub.com/AndreasKl) ) - [`6e499cb`](https://togithub.com/golang-migrate/migrate/commit/6e499cb) Expose configuring cassandra connect timeout through query string (by [@​taywrobel](https://togithub.com/taywrobel) ) - [`4ba6957`](https://togithub.com/golang-migrate/migrate/commit/4ba6957) Resolves [#​647](https://togithub.com/golang-migrate/migrate/issues/647) - Fixes typos in Mongo advisory locking parameters ([#​648](https://togithub.com/golang-migrate/migrate/issues/648)) (by [@​SJrX](https://togithub.com/SJrX) ) - [`9d3babd`](https://togithub.com/golang-migrate/migrate/commit/9d3babd) Run SQL server tests on Azure SQL Edge (by [@​jfhbrook-at-work](https://togithub.com/jfhbrook-at-work) ) - [`5798784`](https://togithub.com/golang-migrate/migrate/commit/5798784) Update Spanner to 1.27 (by [@​mccalltd](https://togithub.com/mccalltd) ) - [`020eda4`](https://togithub.com/golang-migrate/migrate/commit/020eda4) Upgrade cloud.google.com/go/spanner to 1.28.0, which adds JSON_VALUE support (by [@​kylechadha](https://togithub.com/kylechadha) ) - [`9f5ed82`](https://togithub.com/golang-migrate/migrate/commit/9f5ed82) Use DELETE FROM instead of TRUNCATE for MySQL ([#​656](https://togithub.com/golang-migrate/migrate/issues/656)) (by [@​martinarrieta](https://togithub.com/martinarrieta) and [@​antigremlin](https://togithub.com/antigremlin) ) - [`608e4f6`](https://togithub.com/golang-migrate/migrate/commit/608e4f6) Use the recommended v4 in mysql README (by [@​mgenware](https://togithub.com/mgenware) ) - [`a46677e`](https://togithub.com/golang-migrate/migrate/commit/a46677e) bump go-sqlite3 to v1.14.10 (by [@​pankona](https://togithub.com/pankona) ) ##### Migration Sources - [`a2b0bda`](https://togithub.com/golang-migrate/migrate/commit/a2b0bda) change github auth to use oauth token instead of basic. (by [@​Greyeye](https://togithub.com/Greyeye) ) ##### Builds - [`5aa1a03`](https://togithub.com/golang-migrate/migrate/commit/5aa1a03) Bump version of autorest/adal (by [@​jcmuller](https://togithub.com/jcmuller) ) - [`169d0fc`](https://togithub.com/golang-migrate/migrate/commit/169d0fc) Include 2 letter query param key in unit test (by [@​suzaku](https://togithub.com/suzaku) ) - [`331a15d`](https://togithub.com/golang-migrate/migrate/commit/331a15d) Update dktest from v0.3.9 to v0.3.10 to fix upstream security issues (by [@​dhui](https://togithub.com/dhui) ) - [`c277388`](https://togithub.com/golang-migrate/migrate/commit/c277388) Update dktest to v0.3.9 for upstream security vulnerability fixes (by [@​dhui](https://togithub.com/dhui) ) - [`cf68462`](https://togithub.com/golang-migrate/migrate/commit/cf68462) Run gofmt on internal build dir (by [@​dhui](https://togithub.com/dhui) ) - [`fc7f720`](https://togithub.com/golang-migrate/migrate/commit/fc7f720) refactor: use sort.Slice (by [@​suzaku](https://togithub.com/suzaku) ) - [`918e13a`](https://togithub.com/golang-migrate/migrate/commit/918e13a) Upgrade containerd and image-spec for the vulnerabilities ([#​662](https://togithub.com/golang-migrate/migrate/issues/662)) (by [@​mopp](https://togithub.com/mopp) ) - [`4f82413`](https://togithub.com/golang-migrate/migrate/commit/4f82413) len(k) is guaranteed to be greater than 1 in this case (by [@​suzaku](https://togithub.com/suzaku) ) Thank you for your hard work and all your contributions! ### [`v4.15.1`](https://togithub.com/golang-migrate/migrate/releases/tag/v4.15.1) [Compare Source](https://togithub.com/golang-migrate/migrate/compare/v4.15.0...v4.15.1) #### Changes ##### Database Drivers - Update gosnowflake from v1.4.3 to v1.6.3 to fix security warnings ([#​632](https://togithub.com/golang-migrate/migrate/issues/632) & [#​637](https://togithub.com/golang-migrate/migrate/issues/637)). Thanks [@​nicholas-mainardi](https://togithub.com/nicholas-mainardi) and [@​obitech](https://togithub.com/obitech) for reporting the issue! - Add unofficial support for AWS Keyspaces to the Cassandra DB driver by `DELETE`ing the schema version table instead of using `TRUNCATE` thanks to [@​florentsolt](https://togithub.com/florentsolt) and [@​Baumanar](https://togithub.com/Baumanar) ([#​634](https://togithub.com/golang-migrate/migrate/issues/634)) ##### Docker Image - Fixed CLI binary file location ([https://github.com/golang-migrate/migrate/issues/625](https://togithub.com/golang-migrate/migrate/issues/625)) thanks to [@​Fontinalis](https://togithub.com/Fontinalis) ([https://github.com/golang-migrate/migrate/pull/628](https://togithub.com/golang-migrate/migrate/pull/628)) ##### Builds - Update dktest to v0.3.7 to fix security warnings ([#​632](https://togithub.com/golang-migrate/migrate/issues/632)). Thanks [@​nicholas-mainardi](https://togithub.com/nicholas-mainardi) for reporting the issue! </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
Starting with v4.15.0, the
migrate
binary is no longer present at/usr/local/bin/migrate
, but has moved to/usr/bin/migrate
.Steps to Reproduce
Steps to reproduce the behavior:
Expected Behavior
Expected the binary to remain in
/usr/local/bin/migrate
since this was a minor version bump and compatibility was expected, since no mention was made of this change in the release notes.Migrate Version
v4.15.0
Additional context
I bundle the
migrate
binary into another image like this:Of course, if the path changes, the image build breaks as well.
To be clear, this is a minor issue, and I'm totally OK with tweaking my
Dockerfile
to adjust, however this was a surprise, and not listed in the release notes.The text was updated successfully, but these errors were encountered: