Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoquit should be enabled by default #1761

Closed
ladyrick opened this issue Jun 25, 2024 · 6 comments
Closed

autoquit should be enabled by default #1761

ladyrick opened this issue Jun 25, 2024 · 6 comments

Comments

@ladyrick
Copy link

When I use lf and exit, there is a server process leave there forever. It doesn't auto exit.

I think lf's server should works like tmux server: when all client exits, the server should close itself.

@ladyrick
Copy link
Author

I watched about 30 mins. I'm sure the server cannot auto exit.

@joelim-work
Copy link
Collaborator

You need to use set autoquit true, see https://github.com/gokcehan/lf/blob/master/doc.md#autoquit-bool-default-false for more information.

@ladyrick
Copy link
Author

OK, thank you for point out that config.

Maybe make autoquit default true is better? I use lf as an out-of-the-box tool. I put it on a distributed filesystem and use it in many different machines. I think such a tool shouldn't leave anything behind by default.

@joelim-work
Copy link
Collaborator

So I searched through the previous issues, the reason why autoquit is disabled by default comes from #177 (comment):

A new autoquit option is added to automatically quit server when there are no connected clients left. This option is off by default to keep the old behavior. I have added this as an option to avoid respawning server repeatedly when there is often a single client involved but more clients are spawned from time to time.

I personally don't have much opinion on what the default should be either way.

@joelim-work
Copy link
Collaborator

For what it's worth, tmux server automatically quits when there's no more remaining sessions.

@joelim-work joelim-work changed the title lf server cannot auto exit autoquit should be enabled by default Jun 25, 2024
@joelim-work
Copy link
Collaborator

As this is an opinionated request, I am closing this in favor of a poll, see #1767

If there is enough support, I will consider changing the default value for autoquit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants