Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated readme with linters and Optional method + removed FailNow from MinimockFinish + fixed tests #107

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Updated readme with linters and Optional method + removed FailNow from MinimockFinish + fixed tests #107

merged 5 commits into from
Jun 7, 2024

Conversation

zcolleen
Copy link
Collaborator

@zcolleen zcolleen commented Jun 4, 2024

genesor
genesor reviewed Jun 5, 2024
View reviewed changes
template.go Show resolved Hide resolved
@hexdigest
Copy link
Collaborator

@zcolleen let's remove the FailNow method from the Tester interface definition if we don't call it anymore as @genesor mentioned above

@zcolleen
Copy link
Collaborator Author

zcolleen commented Jun 6, 2024

removed FailNow from interface

@zcolleen zcolleen merged commit 48df40b into gojuno:master Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genesor genesor genesor left review comments

@hexdigest hexdigest hexdigest approved these changes

@auvn auvn Awaiting requested review from auvn auvn is a code owner

@regeda regeda Awaiting requested review from regeda regeda is a code owner

@superstas superstas Awaiting requested review from superstas superstas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcolleen @hexdigest @genesor