Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to source does not work for vanity import paths #192

Open
kortschak opened this issue Jul 24, 2017 · 12 comments
Open

Link to source does not work for vanity import paths #192

kortschak opened this issue Jul 24, 2017 · 12 comments

Comments

@kortschak
Copy link

Navigate to https://goreportcard.com/report/gonum.org/v1/gonum and click on the first issue.

Expect to resolve link to github backing repository, but does not. Link works for https://goreportcard.com/report/github.com/gonum/gonum used the same way.

@kortschak
Copy link
Author

This is still not working.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Apr 26, 2021
@kortschak
Copy link
Author

This is still not working.

@shawnps
Copy link
Contributor

shawnps commented Apr 26, 2021

@kortschak I'm not too familiar with vanity import paths, do you know how to resolve the path to its GitHub URL?

@shawnps shawnps removed the Stale label Apr 26, 2021
@kortschak
Copy link
Author

Thanks. The information can be obtained from the go-source meta tag of the vanity URL. For example, for gonum.org, you'll find things like this:

<meta name="go-source" content="gonum.org/v1/exp https://github.com/gonum/exp/ https://github.com/gonum/exp/tree/master{/dir} https://github.com/gonum/exp/blob/master{/dir}/{file}#L{line}">
<meta name="go-source" content="gonum.org/v1/gonum https://github.com/gonum/gonum/ https://github.com/gonum/gonum/tree/master{/dir} https://github.com/gonum/gonum/blob/master{/dir}/{file}#L{line}">

The docs for this don't really exist because apparently it was something that came from godoc.org. The commit that added it is here.

See also, golang/go#39559 and golang/go#40477 for proposals around a versioned equivalent.

@shawnps
Copy link
Contributor

shawnps commented Apr 26, 2021

We can probably do something similar to what the Go source is doing (I think it's here), or perhaps this package has something. I'll need to do some more digging.

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Jun 26, 2021
@kortschak
Copy link
Author

unstale

@github-actions github-actions bot removed the Stale label Jun 27, 2021
@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Aug 27, 2021
@kortschak
Copy link
Author

unstale

@github-actions github-actions bot removed the Stale label Aug 28, 2021
@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Oct 27, 2021
@kortschak
Copy link
Author

kortschak commented Oct 27, 2021

unstale

@github-actions github-actions bot removed the Stale label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants