Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Custom Transformer to Model Deployment #15

Merged
merged 19 commits into from
Nov 3, 2020
Merged

Implement Custom Transformer to Model Deployment #15

merged 19 commits into from
Nov 3, 2020

Conversation

ariefrahmansyah
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah commented Oct 29, 2020 •
edited
Loading

This PR allows users to deploy their Transformer Docker image that contains pre/post-processing code.

Changes:

  • API
    • Append Transformer Spec to InferenceService Spec
    • Update Model Version Endpoint API (Deploy, Redeploy, Get, List)
    • Add unit test
    • Update Swagger spec
  • UI - Update Model Version Deployment page to include Transformer configuration
  • SDK - Update deploy() function to accept new optional arg: transformer
    • Add E2E test

Model version deployment page preview:

transformer-deploy

@pradithya
Copy link
Member

You'll need to include end to end test to the to do list

@ariefrahmansyah
Copy link
Contributor Author

You'll need to include end to end test to the to do list

Yes. The e2e tests will be included in Python SDK test

@pradithya
Copy link
Member

After a model+transformer is deployed, is there a way to see the configuration in UI?

@ariefrahmansyah
Copy link
Contributor Author

After a model+transformer is deployed, is there a way to see the configuration in UI?

Great question. There's no special page for displaying model version configuration, but we can use the redeploy page to display it. Something like this:

image

We can have separate PR for dedicated model version page.

@pradithya
Copy link
Member

After a model+transformer is deployed, is there a way to see the configuration in UI?

Great question. There's no special page for displaying model version configuration, but we can use the redeploy page to display it. Something like this:

image

We can have separate PR for dedicated model version page.

Can you create an issue for this?

@ariefrahmansyah ariefrahmansyah mentioned this pull request Oct 29, 2020
Closed
@pradithya
Copy link
Member

LGTM

@ariefrahmansyah ariefrahmansyah mentioned this pull request Oct 29, 2020
Open
@ariefrahmansyah ariefrahmansyah merged commit 6ffeda3 into main Nov 3, 2020
@ariefrahmansyah ariefrahmansyah deleted the add-transformer branch November 3, 2020 02:31
pradithya pushed a commit that referenced this pull request Oct 3, 2022
@ariefrahmansyah
Implement Custom Transformer to Model Deployment (#15)
0b0aadc 
* Implement Transformer to Version Endpoint

* Add transformer config on deployment page UI

* Update API port to 8080 as 3000 used by UI

* Update swagger api spec -- add transformer

* Add env vars to transformer object

* Display existing transformer spec in UI

* Update Transformer models gorm relation

* Integrate transformer to sdk

* Preload transformers without joining

* Update merlin-sdk version for pyfunc-server

* Address review - move transformer to models.Service

* Propagate transformer related env vars

* Increase timeout for local pyfunc server test

* Revert timeout for local pyfunc server test

* Add e2e test for transformer via python sdk test

* Fix sdk syntax

* Update API unit test

* Propagate docker registries list

* Cast env vars to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradithya pradithya pradithya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ariefrahmansyah @pradithya