Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

New Theme: Winning - a one page CV with pdf generation #401

Closed
cssandstuff opened this issue Aug 7, 2018 · 10 comments
Closed

New Theme: Winning - a one page CV with pdf generation #401

cssandstuff opened this issue Aug 7, 2018 · 10 comments

Comments

@cssandstuff
Copy link

cssandstuff commented Aug 7, 2018

A one page CV template for Hugo.
Generates a nicely formatted CV from a markdown file.

@onedrawingperday
Copy link
Contributor

Hello @cssandstuff

There is a checklist of requirements you must fill, when submitting a theme here.

Also you have not included a link to your theme's repository.

@cssandstuff
Copy link
Author

cssandstuff commented Aug 8, 2018

Theme submission

Link to my theme repository: https://github.com/cssandstuff/hugo-theme-winning

I made sure that...

  • the repository contains a good README.md describing my theme
  • an open source license has been added to LICENSE.md
  • all metadata have been added to theme.toml
  • screenshots have been added in the images/ folder with the required dimensions
  • in case I'm using a customized demo via the exampleSite folder that
    • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
    • the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
  • I tested my theme against the gohugoio/HugoBasicExample
    • I've checked the developer tools' console in my browser for error messages

@cssandstuff
Copy link
Author

@onedrawingperday sorry, originally included the checklist but then edited it out. Hope that helps.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Aug 8, 2018

@cssandstuff

I tested your theme with the build script for the Hugo Themes website and everything works! 👍

There are only a couple of minor changes that you need to do:

  • In your example site's config please change line 3 to the following: theme = "hugo-theme-winning" (everything needs to be lower case).

  • In your theme's README please include an absolute link to your theme's LICENCE (see how other themes have included this link on the Hugo site).

Please do the above and I will mark your theme as ready to be added to the Themes site.

@cssandstuff
Copy link
Author

Cool, done!
thanks @onedrawingperday

@onedrawingperday
Copy link
Contributor

@digitalcraftsman This theme is ready to be added to the website.

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Aug 8, 2018

Thank your for submitting this beautiful theme 👍

@cssandstuff I've checked the generated demo of your theme and noticed that assets like the favicon and stylesheets can't be found.

The problem is that you link the minified version of the stylesheet, e.g. css/main.min.css, but only css/main.css exists in the static directory. Same applies to css/belmu.min.css.

Furthermore, the favicon can't be found because the actual file has the resolution as suffix.

Please fix this issues before the theme will be promoted on Twitter.

@onedrawingperday
Copy link
Contributor

@digitalcraftsman
I'm very sorry I didn't catch these errors when I tested the demo with the Build Script.

It turns out that in baseof.html there is the following:

    {{ if eq (getenv "HUGO_ENV") "production" | or (eq .Site.Params.env "production")  }}
      <link href='{{ "css/belmu.min.css" | absURL }}?{{ now.UnixNano }}' rel='stylesheet' type="text/css" />
      <link href='{{ "css/main.min.css" | absURL }}?{{ now.UnixNano }}' rel='stylesheet' type="text/css" />
    {{ else }}
      <link href='{{ "css/belmu.css" | absURL }}?{{ now.UnixNano }}' rel='stylesheet' type="text/css" />
      <link href='{{ "css/main.css" | absURL }}?{{ now.UnixNano }}' rel='stylesheet' type="text/css" />
    {{ end }}

So I got the CSS rendered with the Build Script because the minified versions are only called when in production.

Here is the screenshot of the demo locally:
screenshot_2018-08-09_00-48-47

But still I also didn't notice the missing favicon...

Anyway I'll keep my eyes wide open from now on for cases like this one.

@cssandstuff
Copy link
Author

Sorry for missing that and causing you extra work. I've added a favicon and also generated the appropriate minified css files. Also have included a postcss.config.js to help with running a postcss task for anyone that needs it

@digitalcraftsman
Copy link
Member

Thanks @cssandstuff for fixing this issues 👍

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants