New theme: Minimal Academic

[jhu247]

Theme submission

Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.

Link to my theme repository: https://github.com/jhu724/minimal-academic

I made sure that...

• the repository contains a good README.md describing my theme
• an open source license has been added to LICENSE.md
• all metadata have been added to theme.toml
• screenshots have been added in the images/ folder with the required dimensions
• in case I'm using a customized demo via the exampleSite folder that
  • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
  • the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
• I tested my theme against the gohugoio/HugoBasicExample
  • I've checked the developer tools' console in my browser for error messages

Feel free to ask questions. We're glad to help.

[onedrawingperday]

Hi @jhu724

Thank you for the theme submission!

I tested your Example site with the build script for the Hugo Themes website and it renders without major errors 👍

But there are the following small issues that need to be fixed:

• The img in the theme's masthead is 404, because the URL is relative to the root, but the theme's Example Site will be published in a sub-directory of the Hugo Themes Site.

Please change lines 2-4 of your masthead_hero.html partial to the following:

{{ $url := (print "img" "/" .Params.hero_image ) }}
.masthead-hero {
  background-image: url("{{ $url | absURL }}");

Basically I used Hugo's print function to store the URL in a variable and then piped the $url variable with absURL to make the img link absolute.

---

NOTE
The above is not the typical fix we offer for themes with missing assets due to relative links, because in your example site you have specified the hero image per content file. (CC / @digitalcraftsman )

---

• Also the size of hero.img is 4.3MB. That's too big. There is a noticeable delay before it loads. Please optimize it.

• Finally in your README you have not included a link to the theme's license. Please add this link and again make it an absolute link to the GitHub URL where the license is located.

Other than that your theme is fine!

Please do the above so that I can mark your theme as ready to be added to the website.

Thanks!

[jhu247]

Hi @onedrawingperday,

Thanks for your review. I've fixed all of your points, please let me know if there's anything else!

[onedrawingperday]

@jhu724 Thank you for making the changes. Everything is looking good on my end!

@digitalcraftsman This theme is ready to be added to the website.

EDIT

Your website https://joshuahu.io/ seems to be down at the moment @jhu724
When I checked earlier it was online. (Just thought that you should know).

[digitalcraftsman]

@jhu724 your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

[jhu247]

Thanks for letting me know about my site being down @onedrawingperday.

Thanks @digitalcraftsman!