commands: Show server error info in browser #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current set of information elements on the error page:
Oh, and that is not it is supposed to look ... |
bep
force-pushed
the
server-error
branch
6 times, most recently
from
7aead85 to
6c68e67
Compare
|
Some more informational elements to put in there, but I think this will be mighty useful. (and yes, I see the typo). |
bep
force-pushed
the
server-error
branch
7 times, most recently
from
6a566c4 to
49da30a
Compare
awulkan
reviewed
Oct 6, 2018
hugolib/paths/paths.go
Outdated
| @@ -83,7 +83,7 @@ func New(fs *hugofs.Fs, cfg config.Provider) (*Paths, error) { | |||
| baseURL, err := newBaseURLFromString(baseURLstr) | |||
|
|
|||
| if err != nil { | |||
| return nil, fmt.Errorf("Failed to create baseURL from %q: %s", baseURLstr, err) | |||
| return nil, fmt.Errorf("cailed to create baseURL from %q: %s", baseURLstr, err) | |||
bep
force-pushed
the
server-error
branch
8 times, most recently
from
4b760aa to
4faa092
Compare
|
|
bep
force-pushed
the
server-error
branch
5 times, most recently
from
e70fd3c to
d64b483
Compare
bep
force-pushed
the
server-error
branch
7 times, most recently
from
5f0d6df to
177b4b1
Compare
bep
force-pushed
the
server-error
branch
5 times, most recently
from
144e9cf to
09ca1d2
Compare
bep
changed the title
bep
force-pushed
the
server-error
branch
3 times, most recently
from
3f3bf7c to
8a887ab
Compare
The main item in this commit is showing of errors with a file context when running `hugo server`. This can be turned off: `hugo server --disableBrowserError` (can also be set in `config.toml`). But to get there, the error handling in Hugo needed a revision. There are some items left TODO for commits soon to follow, most notable errors in content and config files. Fixes gohugoio#5284 Fixes gohugoio#5290 See gohugoio#5325 See gohugoio#5324
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5284