-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Org mode improvements (extend markdownify to support all markup formats) #6043
Org mode improvements (extend markdownify to support all markup formats) #6043
Conversation
We need to stop a minute and think a little about the name. I may have thought these "ify" function names was clever (I think we stole it from Jekyll), but I'm not so sure anymore. I suggest we call the new one That said, we also need to specify the block (paragraphs) vs inline behaviour of such func. There are miles of discussions about this elsewhere, so I will not go into details. /cc @kaushalmodi @regisphilibert and the paragraph riders. |
I agree that the "ify" names are getting old.
How about Can we have something like:
I feel like above are readable as in plain English too. |
The current namespace is |
OK, understood.
I suggested
So.. how about a middle ground.. Then you can have:
I think |
I'm sorry I don't have any suggestion here. But for me Markup in the global sense is not HTML only, it's an ensemble of factors determining the look of your page. CSS is part of the "Markup". Originally these the little handwritten comments added next to the text to indicate the publisher how those element should be "styled" on once printed. |
@regisphilibert As an aside.. that you mention:
https://shadycharacters.co.uk/ is an awesome read if you are interested in such topics related to publishing and special characters 😃 |
I don't care either way but I'm unsure where to go from here. |
Given that no one has a preference, but I do, @bep, does my proposal in #6043 (comment) sound good? 🙂 |
I have a preference, which is the more general term mentioned earlier.
|
@kaushalmodi @niklasfasching sorry, I have been slightly distracted lately. I think I will delay parts of this discussion to a later time. For this particular PR I will say that we cannot add another function with a different name but with almost identical functionality (you have no idea how much time just explaining the difference to people will add up to, even if we add fantastic docs). So, also saying that in the future we need something to indicate block vs inline for this, I suggest that we:
The above will map fairly nicely to the |
Bump. |
Got distracted - I'll look into this on the weekend :) |
see 5589. We're not introducing another function (htmlify) with a different name but with almost identical functionality - rather, as we plan to switch to a generalized .Markup function later on, we'll go with an intermediate solution. We extend markdownify with an (optional) options map that let's the user specify the markup format. See the PR of this commit for a more extensive discussion of the reasoning behind this.
This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help. |
I will probably replace this PR now ... I have thought about this, and I think /cc @regisphilibert |
I'm a bit confused here as of the purpose of this If I'm working on a JSON template file and I use |
@regisphilibert I changed my mind as I wrote it ... See my update. You are too fast. |
Yes |
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This commit also revises the change detection for templates used by content files in server mode. Fixes gohugoio#6545 Fixes gohugoio#4663 Closes gohugoio#6043
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Org.toHTML
function [go-org] #5589)