Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider trimming trailing URL slashes #5098

Closed
nhooyr opened this issue Aug 20, 2018 · 3 comments
Closed

Reconsider trimming trailing URL slashes #5098

nhooyr opened this issue Aug 20, 2018 · 3 comments

Comments

@nhooyr
Copy link

nhooyr commented Aug 20, 2018

See the closed PR #3934 that implements this feature.

Given the activity in that thread, many previous discussions and even blog posts regarding how to get around it, the community clearly wants this feature.

It's worth revisiting this.

@bep bep changed the title reconsider trimming trailing URL slashes Reconsider trimming trailing URL slashes Aug 21, 2018
@anthonyfok
Copy link
Member

anthonyfok commented Aug 25, 2018

Hi @nhooyr, thanks for raising this issue.

I am an occasional contributor and didn't notice #3934's existence until now, and reopened PR #3934, but noticed several issues:

  1. The CLA was not signed. (Was it ever signed before?)
  2. Due to the age of the PR, it now has quite a bit of merge conflicts that need to be resolved.
  3. I think it would be better if there is an accompanying addition to the docs as to how to properly set up each web server or each service to have such trimmed-trailing-URL-slashes working.

These problems need to be resolved, and of course, a consensus reached, before things can move forward.

@stale
Copy link

stale bot commented Dec 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants