Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock when there are errors in Page metadata #4526

Closed
chuanhhoang opened this issue Mar 23, 2018 · 6 comments
Closed

Deadlock when there are errors in Page metadata #4526

chuanhhoang opened this issue Mar 23, 2018 · 6 comments
Milestone

Comments

@chuanhhoang
Copy link

ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-a-modest-proposal-and-other-satires-an-argument-against-the-abolition-of-christianity-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'A' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-anne-bradstreet-poems-the-flesh-and-the-spirit-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'T' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-a-modest-proposal-and-other-satires-a-modest-proposal-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'A' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/just-how-you-can-discover-restaurant-supply-wholesale.md": Near line 1 (last key parsed 'title'): invalid escape character '\''; only the following escape characters are allowed: \b, \t, \n, \f, \r, \", \\, \uXXXX, and \UXXXXXXXX
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-cathedral-careful-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'C' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-anne-bradstreet-poems-for-deliverance-from-a-fever-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'F' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-american-beauty-scene-25-you-couldnt-be-ordinary-if-you-tried-through-scene-27-my-stupid-little-life-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'Y' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-allen-ginsbergs-poetry-howl-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'H' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/introducing-your-restaurant-online.md": Near line 1 (last key parsed 'title'): invalid escape character '\''; only the following escape characters are allowed: \b, \t, \n, \f, \r, \", \\, \uXXXX, and \UXXXXXXXX
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-american-beauty-scene-17-pass-the-asparagus-through-scene-20-massive-psychological-damage-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'P' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-cane-kabnis-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'K' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-andrew-marvell-poems-the-mower-to-the-glowworms-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'T' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-catching-fire-part-1-the-spark-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'T' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/kingkong.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'A' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-anne-bradstreet-poems-on-my-dear-grand-child-simon-bradstreet-who-dyed-on-16-novemb-1669-being-but-one-moneth-and-one-day-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'O' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-a-journal-of-the-plague-year-in-other-cases-some-had-gardens-and-walls-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'I' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-american-beauty-scene-13-moms-mad-through-scene-16-the-most-beautiful-thing-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'M' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-catching-fire-part-3-the-enemy-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'T' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-a-child-called-it-dave-pelzer-1-by-dave-pelzer-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'I' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-anne-bradstreet-poems-in-reference-to-her-children-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'I' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-cathedral-vitamins-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'V' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-cathedral-cathedral-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'C' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-andrew-marvell-poems-damon-the-mower-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'D' instead
ERROR 2018/03/23 19:45:51 failed to parse page metadata for "post/pdf-epub-anne-bradstreet-poems-the-prologue-summary-and-analysis-ebook-full-text.md": Near line 1 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got 'T' instead

Hugo got stuck here in page_bundler.go:

	if err := g2.Wait(); err != nil {
		return err
	}

In my opinion, Hugo should exit with an error code

@moorereason
Copy link
Contributor

Can you provide a minimal example of metadata that triggers this behavior?

@chuanhhoang
Copy link
Author

I just uploaded an archive of posts to DropBox https://www.dropbox.com/s/f7d4j98lyx6xcan/Archive.zip?dl=0
Could you check it out?

@moorereason
Copy link
Contributor

Many of your page titles have unescaped double-quotes inside them which is causing all of the TOML parse errors you're seeing. For example:

title = "PDF EPUB: Anne Bradstreet: Poems "The Prologue Summary And Analysis EBook Full Text  "

Should be one of:

title = 'PDF EPUB: Anne Bradstreet: Poems "The Prologue Summary And Analysis EBook Full Text  '
title = "PDF EPUB: Anne Bradstreet: Poems \"The Prologue Summary And Analysis EBook Full Text  "
title = """PDF EPUB: Anne Bradstreet: Poems "The Prologue Summary And Analysis EBook Full Text  """

However, parsing errors shouldn't cause Hugo to deadlock. We'll need more details about your setup to validate your claims.

@bep bep added the Bug label Mar 23, 2018
@bep bep added this to the v0.38 milestone Mar 23, 2018
@bep
Copy link
Member

bep commented Mar 24, 2018

I can reproduce this. Surprised no-one has stumbled on to this... I will fix. Thanks for reporting.

@chuanhhoang
Copy link
Author

@moorereason Yes, those illegible characters are for a purpose. We host a lot of Hugo blogs on our server for customers. Having bad content from a customer should not etc... brings a whole server down due to deadlocks.

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants