Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal twitter card etc. templates to (also) use images in .Resources #4349

Closed
bep opened this issue Jan 28, 2018 · 6 comments
Closed

Comments

@bep
Copy link
Member

bep commented Jan 28, 2018

This is the new order for Twitter card:

  • Page.Params.images if set
  • Image resources: images with name "feature" (priority), "cover", "thumbnail"
  • Site.Params.images if set

The above should not break existing sites.

We will have to revisit the rest of the image usage later.

@bep bep added this to the v0.35 milestone Jan 28, 2018
@bep
Copy link
Member Author

bep commented Jan 28, 2018

@regisphilibert
Copy link
Member

Yes GetMatch "**featured*" is what I used for my portfolio to find the project's feature image. So I would go with this.
No garantee people won't have non image files called this way though...

@regisphilibert
Copy link
Member

Wordpress has been using "thumbnail" for the past decade and it doesn't apply anymore

@bep
Copy link
Member Author

bep commented Jan 28, 2018

No garantee people won't have non image files called this way though...

Not sure how that could be a problem, as long as they don't name them "*.png" and similar. Thumbnail is something different.

@regisphilibert
Copy link
Member

regisphilibert commented Jan 28, 2018

Oh and I would recommand **feature* rather than **featured*

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants