From acc14b4646d849e09e8da37552d4f4f777d0fce2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Wed, 24 Oct 2018 14:02:34 +0200 Subject: [PATCH] hugolib: Adjust error test to make it pass on Go tip --- hugolib/hugo_sites_build_errors_test.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hugolib/hugo_sites_build_errors_test.go b/hugolib/hugo_sites_build_errors_test.go index 8c501622590..a5825b35f43 100644 --- a/hugolib/hugo_sites_build_errors_test.go +++ b/hugolib/hugo_sites_build_errors_test.go @@ -3,6 +3,7 @@ package hugolib import ( "fmt" "path/filepath" + "runtime" "strings" "testing" @@ -199,14 +200,23 @@ func TestSiteBuildErrors(t *testing.T) { }, }, { + // See https://github.com/gohugoio/hugo/issues/5327 name: "Panic in template Execute", fileType: single, fileFixer: func(content string) string { return strings.Replace(content, ".Title", ".Parent.Parent.Parent", 1) }, + assertBuildError: func(a testSiteBuildErrorAsserter, err error) { assert.Error(err) - assert.Contains(err.Error(), `execute of template failed: panic in Execute`) + // This is fixed in latest Go source + if strings.Contains(runtime.Version(), "devel") { + fe := a.getFileError(err) + assert.Equal(5, fe.LineNumber) + assert.Equal(21, fe.ColumnNumber) + } else { + assert.Contains(err.Error(), `execute of template failed: panic in Execute`) + } }, }, }