Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API(scan,volumes,jobservice,scanner,label,securityhub,catalog) permission testcases #19595

Conversation

YangJiao0817
Copy link
Member

Add scan,volumes,jobservice,scanner,label,securityhub,catalog permission testcases

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #19595 (86b3a5f) into main (13ae233) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19595      +/-   ##
==========================================
- Coverage   45.37%   45.29%   -0.08%     
==========================================
  Files         244      244              
  Lines       13325    13325              
  Branches     2719     2719              
==========================================
- Hits         6046     6036      -10     
- Misses       6976     6986      +10     
  Partials      303      303              
Flag Coverage Δ
unittests 45.29% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@YangJiao0817 YangJiao0817 force-pushed the add-robot-account-permission-testcase-2 branch from a5dd642 to e9d8304 Compare November 22, 2023 07:40
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) November 22, 2023 08:01
…rmission testcases

Add scan,volumes,jobservice,scanner,label,securityhub,catalog permission testcases

Signed-off-by: Yang Jiao <[email protected]>
@YangJiao0817 YangJiao0817 force-pushed the add-robot-account-permission-testcase-2 branch from e9d8304 to 86b3a5f Compare November 22, 2023 08:31
@YangJiao0817 YangJiao0817 merged commit 45b41d4 into goharbor:main Nov 22, 2023
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
…rmission testcases (goharbor#19595)

Add scan,volumes,jobservice,scanner,label,securityhub,catalog permission testcases

Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants