Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick]Support searching artifacts by specified tag name #18176

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Feb 6, 2023

1.Fixes #18082
2.Update CSS

Signed-off-by: AllForNothing [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  1.Fixes goharbor#18082
  2.Update CSS

Signed-off-by: AllForNothing <[email protected]>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #18176 (5884bba) into release-2.7.0 (ab5c594) will increase coverage by 0.00%.
The diff coverage is 58.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.7.0   #18176   +/-   ##
==============================================
  Coverage          66.42%   66.42%           
==============================================
  Files               1012     1012           
  Lines             108599   108609   +10     
  Branches            2674     2677    +3     
==============================================
+ Hits               72135    72148   +13     
+ Misses             32501    32500    -1     
+ Partials            3963     3961    -2     
Flag Coverage Δ
unittests 66.42% <58.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/artifact-list-tab/artifact-list-tab.component.ts 39.83% <0.00%> (-0.22%) ⬇️
...c/app/base/project/repository/artifact/artifact.ts 53.57% <ø> (ø)
...t-tab/artifact-filter/artifact-filter.component.ts 52.63% <77.77%> (+5.96%) ⬆️
src/lib/cache/util.go 73.07% <0.00%> (-15.39%) ⬇️
...g-retention-tasks/tag-retention-tasks.component.ts 75.00% <0.00%> (-9.38%) ⬇️
src/controller/event/topic.go 10.56% <0.00%> (+2.11%) ⬆️
src/jobservice/sync/schedule.go 56.91% <0.00%> (+2.37%) ⬆️
...dashboard/schedule-card/schedule-card.component.ts 46.26% <0.00%> (+2.98%) ⬆️
src/common/utils/passports.go 90.19% <0.00%> (+3.92%) ⬆️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 36.00% <0.00%> (+4.00%) ⬆️

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 7f0bd60 into goharbor:release-2.7.0 Feb 8, 2023
@AllForNothing AllForNothing deleted the 2.7/tag-search branch March 29, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants