This repository has been archived by the owner on Apr 23, 2023. It is now read-only.
Update from upstream repo golang/playground@master #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server.handleEdit handler is being registered to handle the "/" pattern. Its code checks if the request URL path has a "/p/" prefix, and otherwise assumes it's the index page. There's no check if it's some other unsupported URL. As a result, any URL that isn't handled elsewhere serves the index page. For example: https://play.golang.org/foobarbaz This change fixes that so non-existent pages return a 404 Not Found error instead. Also use context.Background() instead of a nil context in a test, per the context package instructions. Change-Id: I4c43492397a6f71bffc1e6a657ff2a523a245f94 Reviewed-on: https://go-review.googlesource.com/129795 Reviewed-by: Brad Fitzpatrick <[email protected]>
The existing implementation only prevents code caching if the code has certain compile-time errors. Code with deterministic runtime errors, such as out of memory errors, are being cached. This causes errors to be returned in the Go Tour if a different user's run caused an error. The cache had to be manually cleared in order to clean out the bad run. This change prevents code that threw an "out of memory" or a "cannot allocate memory" error from being cached. Fixes golang/go#26926 Change-Id: Ib281f3076bc674e7c2f08bf9b5c4be36da22d28e Reviewed-on: https://go-review.googlesource.com/130035 Reviewed-by: Andrew Bonventre <[email protected]>
Use the godoc with the CL 113875. That CL handles the case when there was no output from the user program and vet returned an error. Fixes golang/go#27980 Change-Id: I8f3d5ff477fb930c099fd9780c102c8421403e55 Reviewed-on: https://go-review.googlesource.com/c/140017 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
Go 1.11.1 has been released and should be used. Revert CL 106216 (other than the added test case), because the strict-time.patch has already been applied to the Go repository via CL 105235 in Go 1.11.1. Reference: https://groups.google.com/d/msg/golang-announce/pFXKAfoVJqw/eyDgSLVYAgAJ. Fixes golang/go#28036. Change-Id: Iacf9900a21c4b2f7bf5ac756be2cdbd8ac0be815 Reviewed-on: https://go-review.googlesource.com/c/140097 Reviewed-by: Brad Fitzpatrick <[email protected]>
Fixes golang/go#25462 Change-Id: I11b861352b53f9492cd1f5c6d8c434edd68e4bd9 Reviewed-on: https://go-review.googlesource.com/c/140497 Reviewed-by: Andrew Bonventre <[email protected]>
This CL changes the last line displayed after the program was run to display more detail on what happened. For more details see CL 141477. Dockerfile in playground repo needs to be updated to include x/tools with CL 141477. Updates golang/go#10590 Updates golang/go#25454 Change-Id: I6bdef66e70d693540e4e7d30478ae9f0bf85d1ba Reviewed-on: https://go-review.googlesource.com/c/141478 Reviewed-by: Andrew Bonventre <[email protected]> Run-TryBot: Andrew Bonventre <[email protected]>
Updates golang/go#10590 Updates golang/go#25454 Change-Id: I807608979062f57268bf2b80edbd37d88e74b8f7 Reviewed-on: https://go-review.googlesource.com/c/142637 Reviewed-by: Brad Fitzpatrick <[email protected]>
New fields were added to the response struct in CL 141478. That was not accounted in the TestCommandHandler test. This CL fixes the test by adding required fields. Updates golang/go#25454 Change-Id: I374cef6199235d781bd83a60156ca4f0d90898ee Reviewed-on: https://go-review.googlesource.com/c/144078 Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-by: Yury Smolsky <[email protected]> Reviewed-by: Katie Hockman <[email protected]>
CL 141317 moved the talk content in the content/ subdirectory. This CL follows up on that change by updating an import path accordingly. It fixes the following build error: Step 52/61 : RUN GOOS=nacl GOARCH=amd64p32 go get [...] golang.org/x/talks/2016/applicative/google [...] [...]: cannot find package "golang.org/x/talks/2016/applicative/google" in any of: /usr/local/go/src/golang.org/x/talks/2016/applicative/google (from $GOROOT) /go/src/golang.org/x/talks/2016/applicative/google (from $GOPATH) The command [...] returned a non-zero code: 1 Change-Id: I0b711d32023066a8b4a16ceb4cbe2c7b79d66f77 Reviewed-on: https://go-review.googlesource.com/c/144477 Reviewed-by: Brad Fitzpatrick <[email protected]>
It is important that nondeterministic errors are not cached. Otherwise, playground users may encounter errors from a prevous run when the current run may have otherwise succeeded. The existing implementation prevents runtime OOM errors from being cached. This change prevents compile time OOM errors from being cached as well. See related: https://golang.org/cl/130035 Fixes golang/go#28283 Change-Id: If734915935cc1013bcb9a87d0ae6ecd67505f231 Reviewed-on: https://go-review.googlesource.com/c/144297 Reviewed-by: Dmitri Shuralyov <[email protected]>
This feature was implemented. Change-Id: I6b0d9b121f2ccf517bb0f7c7be7c2aa602456acc Reviewed-on: https://go-review.googlesource.com/c/146617 Reviewed-by: Brad Fitzpatrick <[email protected]>
The previous snippet was created almost 4 years ago in CL 2308. Update to a more modern snippet (created today) for the following reasons: • Apply gofmt (previous one was missing a newline at EOF). • It uses the current ID generation scheme, making it possible to re-create the same snippet in another playground instance. Change-Id: I50157f9a8d313f3c826d4289c91c42049ac5bd0d Reviewed-on: https://go-review.googlesource.com/c/149341 Reviewed-by: Brad Fitzpatrick <[email protected]>
Go 1.12 has been released¹ and should be used, so that it's possible to play with Go programs that rely on Go 1.12-only features. In Go 1.12, build cache is required. Either GOCACHE must be set, or HOME must be set so that GOCACHE can be implicitly deduced. Set HOME and pass it on to the go build invocation inside the compileAndRun function. This fixes the following error, detected by the playground test: 2019/02/26 06:28:44 compile error: build cache is required, but could not be located: GOCACHE is not defined and neither $XDG_CACHE_HOME nor $HOME are defined The command '/bin/sh -c /app/playground test' returned a non-zero code: 1 This is related to issues golang/go#29243 and golang/go#29251, and the fix in CL 154181. ¹ https://groups.google.com/d/msg/golang-announce/Y1RZqnCKUKY/N9yK5c8iBgAJ Fixes golang/go#30397 Change-Id: I44c5c8928060732f31fd935b114568258c7298c7 Reviewed-on: https://go-review.googlesource.com/c/163798 Reviewed-by: Brad Fitzpatrick <[email protected]>
Start using newer versions of dependencies, to reduce tech debt and make future updates more incremental. This change was generated by running make update-deps on linux/amd64, using current versions of all dependencies. Change-Id: I8e76e010a36cd479aa491f722b4eb8ef9fdf89a0 Reviewed-on: https://go-review.googlesource.com/c/163799 Reviewed-by: Brad Fitzpatrick <[email protected]>
Fixes golang/go#30473 Change-Id: Iad5b60b98c12add932fa3be9174fe7ca4dcbb6b2 Reviewed-on: https://go-review.googlesource.com/c/164519 Reviewed-by: Dmitri Shuralyov <[email protected]>
It's unfortunate to introduce an extra step of setting a global configuration value to the deploy process. It would be better if this could be an application-scoped setting specified in the app.yaml configuration. However, that doesn't seem to be possible, and after reading through documentation and waiting to hear any suggestions at golang/go#28046, I have not become aware of a better solution. Document this approach for now, and if we learn of a better solution in the future, this can be improved then. Fixes golang/go#28046 Change-Id: I2e9b7bbd38aa8313ff6eab0bf99dd2fe48f57544 Reviewed-on: https://go-review.googlesource.com/c/playground/+/164577 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
jessie is old (even by Debian standards) and doesn't even build anymore without changes, as the apt-get contents have moved to an archive URL. Debian stable is stretch these days, so upgrade to that. (Debian buster is almost the next stable, but not quite yet) Change-Id: I633edc56d92cea37c7ed01f6e85b4bea4ff3b412 Reviewed-on: https://go-review.googlesource.com/c/playground/+/176277 Reviewed-by: Dmitri Shuralyov <[email protected]>
Also, modernize the Dockerfile while I'm at it, using multi-stage builds more aggressively, and stop using gitlock (golang/go#26872) and switch to using Go modules to build the playground. (This also turns the playground into a module.) Updates golang/go#31944 Change-Id: Ic6f6152469f1930fd04180a3d1e63ed92ea2cfbd Reviewed-on: https://go-review.googlesource.com/c/playground/+/176317 Reviewed-by: Yury Smolsky <[email protected]>
…pile+run Also, move the tests to their own file and extend them a bit, give them names, and make the test step more verbose (only visible in docker build anyway). They were hogging up the sandbox file. Updates golang/go#31970 Change-Id: Id710ea613c77a5b16cc5e79545c0812d0f4650e3 Reviewed-on: https://go-review.googlesource.com/c/playground/+/176598 Reviewed-by: Andrew Bonventre <[email protected]> Reviewed-by: Yury Smolsky <[email protected]>
Updates golang/go#31944 Change-Id: Iffc0755cca419b72d8facd8ece950e78cdae892e Reviewed-on: https://go-review.googlesource.com/c/playground/+/176940 Reviewed-by: Andrew Bonventre <[email protected]>
Updates golang/go#32040 Updates golang/go#31944 (Notably, you can now include a go.mod file) Change-Id: I56846e86d3d98fdf4cac388b5b284dbc187e3b36 Reviewed-on: https://go-review.googlesource.com/c/playground/+/177043 Reviewed-by: Dmitri Shuralyov <[email protected]>
Previously, handleFmt applied gofmt/goimports formatting to .go files only. This change makes it apply formatting to go.mod files as well. The cmd/go/internal/modfile package (well, a non-internal copy thereof) is used to perform the go.mod file formatting. Add test cases for error messages, and fix some cases where the paths weren't accurate. Detect when the error was returned by format.Source and needs to be prefixed by using the fixImports variable instead of checking for the presence of the prefix. This makes the code simpler and more readable. Replace old fs.m[f] usage with fs.Data(f) in fmt.go and txtar_test.go. Updates golang/go#32040 Updates golang/go#31944 Change-Id: Iefef7337f962914817558bcf0c622a952160ac44 Reviewed-on: https://go-review.googlesource.com/c/playground/+/177421 Reviewed-by: Brad Fitzpatrick <[email protected]>
Run quick tests before the slow tests. Change-Id: I52d0d9a72de416201745eff992d84d72409cecae Reviewed-on: https://go-review.googlesource.com/c/playground/+/177477 Reviewed-by: Dmitri Shuralyov <[email protected]>
This will allow us to specify a GO_VERSION at build time. Bumps GO_VERSION to go1.12.6. Moves BUILD_DEPS install step before GO_VERSION which improves intermediate step caching during development. Verified locally with: - docker build --build-arg GO_VERSION=go1.12.6 (and others) - Ran fmt.Println(runtime.Version()) in the playground to verify the version changed. Updates golang/go#32606 Change-Id: Ic57f8a0a3465d7ea3438a31eab5ca90f85333af5 Reviewed-on: https://go-review.googlesource.com/c/playground/+/182180 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Alexander Rakoczy <[email protected]>
This change includes configuration to build and deploy new releases of the Go playground when a new tag of Go is released to Github. The trigger is configured to filter tags to new, non-rc, non-beta releases of Go. This first commit simply implements releasing the current version of Go configured for the playground. Changes to the build process to ensure we're releasing the latest version of Go will be in a follow-up commit. Updates golang/go#32606 Change-Id: I3b518fd3f02efcd8f510fd865f3370bea19f0e9b Reviewed-on: https://go-review.googlesource.com/c/playground/+/183037 Reviewed-by: Dmitri Shuralyov <[email protected]>
This changes the playground Dockerfile to build playground from source. Cloud Builds for playground are triggered when a new Go release is tagged. Go release tags are published to repositories before binary releases are published. This change fetches the tagged source in order to build Go, as a tagged binary release may not be available yet. A binary Go release is still downloaded to be used as the GOROOT_BOOTSTRAP. The build steps use maintq to fetch the latest version of Go. maintq currently only outputs in textproto format, requiring a step to parse the git tag. It might be worth adding a flag or special command to maintq to simplify the output to clarify this step of the release process. It might also be worthwhile to move this step into the Makefile, or a checked-in build script. The trigger steps were tested on Cloud Build without the deployment step. Updates golang/go#32606 Change-Id: I811be6aa6b5fb53fce4491e4b4ed235a0f3e62cb Reviewed-on: https://go-review.googlesource.com/c/playground/+/183403 Reviewed-by: Dmitri Shuralyov <[email protected]>
Removes post-build trigger step of pushing image, and adds a push step step before AppEngine deployment. This ensures that the image we just built is pushed before asking AppEngine to deploy it. This is documented at: https://cloud.google.com/cloud-build/docs/configuring-builds/build-test-deploy-artifacts Cloud Build is authorized to push images to gcr.io. This change was tested by submitting a build with this configuration without the deployment step. Updates golang/go#32606 Change-Id: I4e7cc242566378e4ca6d52244fb81bf410e79314 Reviewed-on: https://go-review.googlesource.com/c/playground/+/185339 Reviewed-by: Dmitri Shuralyov <[email protected]>
This change adds configuration to trigger a playground deploy when master is updated. Configuration for deploying a build with the latest release of go is shared in deploy/deploy.json. Cloud Build configurations have been moved to the deploy directory. In order to help share configurations, the build triggers will create a separate deployment build asynchronously. The README is updated to help describe common deployment scenarios. Tested deploy steps with README instructions. Updates golang/go#32606 Change-Id: I6eced05d3aa2904135e95e8b40e5a30a5b0b0488 Reviewed-on: https://go-review.googlesource.com/c/playground/+/185341 Reviewed-by: Dmitri Shuralyov <[email protected]>
This changes the build process to use a newly-added latestgo command for determining the latest version of Go. This simplifies the Cloud Build deploy.json significantly. latestgo fetches the latest supported Go releases from maintner, returning the first one. The maintner API always returns at least 2 releases on success, with the first result being the latest supported Go release. Updates golang/go#32606 Change-Id: I9da9101368ac4edfd7651e3f996b5f2dbe51b6c4 Reviewed-on: https://go-review.googlesource.com/c/playground/+/185437 Reviewed-by: Dmitri Shuralyov <[email protected]>
The playground's dependencies were quite stale, causing trybot failures due to an old version of x/sys. Update them. Also fix a stale link to play.golang.org in the README. Fixes golang/go#59218 Change-Id: I8b672883681c25f03375e9abaee189ca2b7c334b Reviewed-on: https://go-review.googlesource.com/c/playground/+/478959 Reviewed-by: Heschi Kreinick <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Robert Findley <[email protected]> Auto-Submit: Robert Findley <[email protected]>
Fixes golang/go#58350 Change-Id: I4bb22a6a1aaebcb965938d78c754c71e1041e431 Reviewed-on: https://go-review.googlesource.com/c/playground/+/467955 Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
CL 467955 inadvertently removed the -prev flag for the latestgo command, causing goprevplay to (surprisingly) revert to building go at tip. Fixes golang/go#59303 Change-Id: I6dc79f8737a36e01405fcdc50b5a908284b361b1 Reviewed-on: https://go-review.googlesource.com/c/playground/+/480235 Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
In golang/go#59303, we observed (surprisingly) that the goprev playground deployment proceeded with deploying using tip Go after the latestgo command failed. Fix the latestgo invocation to exit with a non-zero exit code when latestgo fails. For golang/go#59303 Change-Id: Ie07764b71ce42bddbff6266b0bb8684140d02af4 Reviewed-on: https://go-review.googlesource.com/c/playground/+/480275 Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Change-Id: I875c677d991537ca6209ebf52cba8d1cb36a59e7 GitHub-Last-Rev: 1318c49 GitHub-Pull-Request: #24 Reviewed-on: https://go-review.googlesource.com/c/playground/+/484935 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]>
We sometimes add features we want people to play with to the Go toolchain using GOEXPERIMENT flags. Provide access to these on the playground by looking for // GOEXPERIMENT=foo lines at the top of source files. In particular, this will let people add // GOEXPERIMENT=loopvar and get the loop variable semantics. Change-Id: I4335ab72f2bf417148d18508f2233597d745e847 Reviewed-on: https://go-review.googlesource.com/c/playground/+/511640 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Robert Findley <[email protected]> Run-TryBot: Russ Cox <[email protected]>
Pick up CL 479556 to get the updated version of version.ParseTag, which fixes cmd/latestgo to find go1.21.0. Change-Id: I1b4636276e815bed83e65e726feb85fd46d5b99c Reviewed-on: https://go-review.googlesource.com/c/playground/+/517155 Run-TryBot: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
This unbreaks the gotip build. Change-Id: Ic251015d0b58dc12fd4e5f38350a16a2fd3e103c Reviewed-on: https://go-review.googlesource.com/c/playground/+/517295 Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Robert Findley <[email protected]> Auto-Submit: Robert Findley <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Done with: go get [email protected] go mod tidy go fix ./... Using go1.21.3. For golang/go#60268. Change-Id: I3817780240e082ba076e2c6c9cd45fd3837c3c1d Reviewed-on: https://go-review.googlesource.com/c/playground/+/534736 Reviewed-by: Robert Findley <[email protected]> Commit-Queue: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
Change-Id: Iacba4d6d75cac6b540bf855831873e35df47334f Reviewed-on: https://go-review.googlesource.com/c/playground/+/465999 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Run-TryBot: shuang cui <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> TryBot-Bypass: Dmitri Shuralyov <[email protected]>
Change-Id: I4164647bd3dce8caa84e5990721c099cef4c14d4 Reviewed-on: https://go-review.googlesource.com/c/playground/+/517835 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Run-TryBot: shuang cui <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
CL 398574 added a step to use versionprune and prune old versions of the gotip playground. Apply the same change to the other two for the same reason. Also switch from 'go install' to 'go run' to simplify the invocation, and use a single dash in flags as is canonical style for Go commands. While here, also improve consistency between these files: • apply the change in CL 480275 to deploy.json too • use 'sh' everywhere, instead of a mix of 'bash' and 'sh' • drop GO111MODULE=on since it's the default For golang/go#59303. Change-Id: I921e768d15743a7a93ece8a1f671eaa0ee2e328a Reviewed-on: https://go-review.googlesource.com/c/playground/+/555656 Reviewed-by: Robert Findley <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
While we continue to investigate the miscategorization of internal IPs in playground traffic, add an allow list of a few known problematic IP prefixes that have been manually verified to be US Google IPs. Based on history over the past week, this should get playground snippets working again, at least temporarily. For golang/go#65081 Change-Id: Iccb16e9f6afbdad271198a4e3f23c8adf8b0fe8f Reviewed-on: https://go-review.googlesource.com/c/playground/+/556157 Auto-Submit: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Commit-Queue: Robert Findley <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Robert Findley <[email protected]>
CL 556157 used the http.Request.RemoteAddr for comparing with the allow list of miscategorized IP prefixes. This is incorrect as it is generally 127.0.0.1 for App Engine traffic. Use X-Forwarded-For instead: https://cloud.google.com/appengine/docs/standard/reference/request-headers For golang/go#65081 Change-Id: Ia0861bdf76dd401c8fa1cd0871c09ae901f5a089 Reviewed-on: https://go-review.googlesource.com/c/playground/+/556195 TryBot-Result: Gopher Robot <[email protected]> Commit-Queue: Robert Findley <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Robert Findley <[email protected]> Auto-Submit: Robert Findley <[email protected]>
We have determined that since x/website prevents /_/share traffic from being served for golang.google.cn, we no longer need to guard sharing in x/playground based on X-AppEngine-Country. Fixes golang/go#65081 Change-Id: Iba078d38bc39fe4c532cb6a78c082559f344b6e2 Reviewed-on: https://go-review.googlesource.com/c/playground/+/556315 Run-TryBot: Robert Findley <[email protected]> Commit-Queue: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Previously, `-mod=mod` was included to pull down dependencies. This change executes go mod tidy before building packages, that will allow for go work usage, and address golang/go#40728 Fixes golang/go#54741 Change-Id: I66affc8d2a2e72d958415ea1c052dd3dcf38841e Reviewed-on: https://go-review.googlesource.com/c/playground/+/458895 Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]> Commit-Queue: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
…command" This reverts CL 458895. Reason for revert: Broke the playground with "no space left on device". Change-Id: I0ae0a8489446bd66b49196dce64ee79de6f85486 Reviewed-on: https://go-review.googlesource.com/c/playground/+/560460 Commit-Queue: Robert Findley <[email protected]> Run-TryBot: Robert Findley <[email protected]> Auto-Submit: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
Done with: go get golang.org/x/mod go mod tidy Using go1.22.0. For golang/go#65891. Change-Id: I79ec0620be780e3cf5ecbbc0bde6b4e19febce99 Reviewed-on: https://go-review.googlesource.com/c/playground/+/566275 Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Very minor tweaks: - Remove (c) pseudosymbol. - Remove "All Rights Reserved." - Change "Google Inc." (no longer exists) to "Google LLC". [git-generate] echo ' ,s/\(c\) // ,s/ All rights reserved.// ,s/Google Inc./Google LLC/ w q ' | sam -d LICENSE Change-Id: I18d8fb86ef67f4e0b513f4078f07409df16f45a0 Reviewed-on: https://go-review.googlesource.com/c/playground/+/598582 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Russ Cox <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Previously, multifile code with tests was failing with error saying that function main is undeclared in the main package. This change aims to restrict number of files restriction to allow tests to run. The change also fixes test output typo. To test this change, cd to sandbox and run `make runlocal`. In a second terminal, stay on the root of the project and run `make test_gvisor`. Without removing `files.Num() == 1`, you would see the following error: ``` resp.Errors = "runtime.main_main·f: function main is undeclared in the main package\n", want "" ``` Fixes golang/go#32403 Change-Id: I98c0de6bf7a80559749a12a19ae3cc19b9d48e91 Reviewed-on: https://go-review.googlesource.com/c/playground/+/462835 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Matloob <[email protected]> Reviewed-by: Robert Findley <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
This avoids triggering the go1.24 vet check for ill-formed Test (etc) function names. Fixes golang/go#68999 Change-Id: I60a21e99dd4835f20c3e999a1ee8f29451cf653b Reviewed-on: https://go-review.googlesource.com/c/playground/+/607835 Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Now that the Go bootstrap version has been updated, the tip playground deployment is failing. We need a better long-term fix, but for now just bump the bootstrap version. Also update the (very old) Go version in the sandbox Dockerfile. Updates golang/go#69238 Change-Id: I14f1bc59904d8fd83cac0aca7efc2dc932a2ce64 Reviewed-on: https://go-review.googlesource.com/c/playground/+/610336 Reviewed-by: Tim King <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I6a14f2d53ec6db4d842b41718fe283f0516f118b Reviewed-on: https://go-review.googlesource.com/c/playground/+/611937 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: David Chase <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
To avoid having to maintain GO_BOOTSTRAP_VERSION in the playground Dockerfile, always use the latest "published" minor of the previous Go release as the bootstrap version, which per golang/go#54265 should always be a sufficiently recent bootstrap version. Here "published" means that the toolchain must exist, since it will be downloaded for bootstrap. To enable this, add a `-toolchain` flag to the latestgo command, which selects versions from the set of published toolchains, rather than from Gerrit tags. Fixes golang/go#69238 Change-Id: Ib4d4d7f2c0d5c4fbdccfec5d8bb83c040e0c5384 Reviewed-on: https://go-review.googlesource.com/c/playground/+/610675 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
s/--build_arg/build-arg. Updates golang/go#69238 Change-Id: Idd502f2f01049e2ae65949e6a1ac894cc5feaa2a Reviewed-on: https://go-review.googlesource.com/c/playground/+/612455 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Experiments extracted from GOEXPERIMENT were not being passed to vet. Some experiments, such as aliastypeparams, affect vet as well, and so must be set in the vet environment. Change-Id: I7d72c50f5237753b84d26a27fbb09d9bfcf34626 Reviewed-on: https://go-review.googlesource.com/c/playground/+/612456 Reviewed-by: Robert Griesemer <[email protected]> Auto-Submit: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Tim King <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I69d37ffb2f1a044c2876fe17a45c00470fdccfb7 Reviewed-on: https://go-review.googlesource.com/c/playground/+/617661 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Arg `GO_BOOTSTRAP_VERSION` resolved from incorrect value, references are empty when arg is not supplied in docker build command. "AS" capitalised to silence warning `WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 62)` Change-Id: Ie7c54e027f564b9b1336ca7d73af02d7fb1863ec Reviewed-on: https://go-review.googlesource.com/c/playground/+/618777 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Auto-Submit: Robert Findley <[email protected]> Reviewed-by: Robert Findley <[email protected]>
Change-Id: I6838338ebb8d2130f1442fc844ac787eeb9c8c1f Reviewed-on: https://go-review.googlesource.com/c/playground/+/625755 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I5235f25f6df0584b22e16800bd116ecd58b58994 Reviewed-on: https://go-review.googlesource.com/c/playground/+/626597 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: David Chase <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The upstream repository
golang/playground@masterhas some new changes that aren't in this fork. So, here they are, ready to be merged! 🎉If this pull request can be merged without conflict, you can publish your software with these new changes. Otherwise, fix any merge conflicts by clicking the
Resolve Conflictsbutton.If you like Backstroke, consider donating to help us pay for infrastructure here. Backstroke is a completely open source project that's free to use, but we survive on sponsorships and donations. Thanks for your support! Help out Backstroke.
Created by Backstroke (I'm a bot!)