Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stutter in flock.NewLock #25

Closed
egonelbre opened this issue Sep 15, 2018 · 3 comments · Fixed by #32
Closed

Stutter in flock.NewLock #25

egonelbre opened this issue Sep 15, 2018 · 3 comments · Fixed by #32
Labels
enhancement

Comments

@egonelbre
Copy link
Contributor

egonelbre commented Sep 15, 2018 •
edited
Loading

Issue for deciding whether changing flock.NewLock -> flock.New, is worth the compatibility change.
@theckman
Copy link
Member

/cc @gofrs/all -- I'd love feedback on this from you.

@leighmcculloch
Copy link

I don't think it's a meaningful enough change to warrant breaking the API for.

@dylan-bourque
Copy link
Member

Add flock.New() now with a release note and deprecate flock.NewLock() later

@egonelbre egonelbre mentioned this issue Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add New method and deprecate NewFlock
5 participants
@egonelbre @leighmcculloch @theckman @ldez @dylan-bourque